add missing OpenShiftReadiness.isReadinessApplicable

[Ladicek]

This is to make OpenShiftReadiness a drop-in replacement
for Readiness for OpenShift users.

Fixes #2557.

Description

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[centos-ci]

Can one of the admins verify this patch?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

0.0% Coverage
0.0% Duplication

The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

[manusa]

thx!

[manusa]

[merge]

[pjgg]

@rohanKanojia
Do you know, in which version this method is going to be available? , I mean public ...

protected boolean isReadinessApplicable(HasMetadata item) -> public boolean isReadinessApplicable(HasMetadata item)

[rohanKanojia]

From commit info it looks like this change is available since 4.13.0 to latest releases

[pjgg]

@rohanKanojia

https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/internal/readiness/Readiness.java#L85

Seems that was reverted in some merge.

On this one:
d8eb90c#diff-463619f17f69ff1bb425b571477c5bad6d786afaf2c974a7713c5982242edb79

[manusa]

@rohanKanojia
Do you know, in which version this method is going to be available? , I mean public ...

protected boolean isReadinessApplicable(HasMetadata item) -> public boolean isReadinessApplicable(HasMetadata item)

Hi @pjgg
What's your use-case, why do you need that method to be public?

[Ladicek]

We should probably file a separate issue, something like "make the Readiness API public". I've personally used that API on multiple occasions, for example in a test framework that deploys applications and then waits for their readiness. Or in tests that rolls out new applications versions and, again, waits for their readiness.

[rohanKanojia]

@Ladicek : I think there is an issue already for this: #2838

[Ladicek]

Nice, didn't know that, thanks!