Edit improvement #2640
Merged
Edit improvement #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Nov 27, 2020
iocanel
force-pushed
the
edit-improvement
branch
from
36ae163
to
1e1fdb8
Compare
|
SonarCloud Quality Gate failed.
|
manusa
approved these changes
Dec 4, 2020
rohanKanojia
reviewed
Dec 4, 2020
| @@ -7,6 +7,7 @@ | |||
| #### Improvements | |||
|
|
|||
| #### Dependency Upgrade | |||
| * edit methods, now accept visitors as vararg or lambda. | |||
There was a problem hiding this comment.
Umm, shouldn't this go in Improvements section?
There was a problem hiding this comment.
ohk, sorry. Just noticed we bumped Sundrio to 0.23.1
There was a problem hiding this comment.
I think it'd be nice to add examples of each new modalities so that users can see the improvements directly.
rohanKanojia
approved these changes
Dec 4, 2020
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2636
And also makes edit more usable.