Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor watchers #2714

Merged
merged 10 commits into from
Jan 15, 2021
Merged

Refactor watchers #2714

merged 10 commits into from
Jan 15, 2021

Conversation

metacosm
Copy link
Collaborator

Description

Refactor watcher code so that more code is shared between implementations.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@metacosm metacosm self-assigned this Jan 11, 2021
@centos-ci
Copy link

Can one of the admins verify this patch?

@metacosm metacosm marked this pull request as ready for review January 12, 2021 09:12
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2021

@metacosm metacosm mentioned this pull request Jan 12, 2021
11 tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@manusa manusa added this to the 5.0.1 milestone Jan 15, 2021
@manusa
Copy link
Member

manusa commented Jan 15, 2021

[merge]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants