Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2687: RawCustomResourceOperationsImpl ignores provided Config #2721

Merged
merged 2 commits into from Jan 18, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jan 13, 2021

Fix #2687

Removed colliding variables from parent OperationSupport class and added
a call to super in constructor

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Jan 14, 2021

I see these checkboxes haven't been checked:
image

Please make sure you thoroughly check all of the CustomResource operations for untyped CRs, especially operations that have to do with configurations such as:

final ConfigBuilder configBuilder = new ConfigBuilder();
configBuilder.withWatchReconnectInterval(500);
configBuilder.withWatchReconnectLimit(5);

I basically opened this issue because when running this example, watch would keep reconnecting after 5 attempts. After a little investigation I discovered the bug.

@manusa manusa added this to the 5.0.1 milestone Jan 15, 2021
…Config

Removed colliding variables from parent OperationSupport class and added
a call to super in constructor
@rohanKanojia rohanKanojia force-pushed the pr/issue2687 branch 2 times, most recently from a396a62 to 96240b5 Compare January 15, 2021 17:23
Added test cases for Raw CustomResource operations
using String, InputStream and raw HashMap
@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Jan 18, 2021

[merge]

@manusa manusa merged commit 671ffb3 into fabric8io:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RawCustomResourceOperationsImpl ignores config
3 participants