Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for flowcontrol.apiserver.k8s.io/v1beta1 FlowSchema and PriorityLevelConfiguration #2984

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Add support for flowcontrol.apiserver.k8s.io/v1beta1 FlowSchema and PriorityLevelConfiguration #2984

merged 1 commit into from
Apr 19, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Apr 12, 2021 •
edited by manusa

Description

  • Added client.flowControl() DSL for FlowControl API resources

Related to #2912

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia mentioned this pull request Apr 12, 2021
Closed
@rohanKanojia rohanKanojia force-pushed the pr/kubernetes-model-flowcontrol branch 3 times, most recently from 14de246 to 22df0cf Compare April 16, 2021 15:49
@rohanKanojia rohanKanojia force-pushed the pr/kubernetes-model-flowcontrol branch from 22df0cf to 3ab7e63 Compare April 16, 2021 17:51
@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

17.4% 17.4% Coverage
1.5% 1.5% Duplication

manusa
manusa approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit c0a0107 into fabric8io:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohanKanojia @manusa @oscerd