Use apiGroupName in generated package for OpenShiftClient Handler/OperationsImpl #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 6, 2021
rohanKanojia
force-pushed
the
pr/openshift-client-handlers-apigroups
branch
from
59af940
to
cddd84b
Compare
rohanKanojia
force-pushed
the
pr/openshift-client-handlers-apigroups
branch
2 times, most recently
from
3975733
to
c10af9a
Compare
|
SonarCloud Quality Gate failed. |
…rationsImpl Right now all OpenShiftClient's Handler/OperationsImpl classes get generated in one package `io.fabric8.openshift.client.handlers`/`io.fabric8.openshift.client.dsl.internal` This creates problems if we want to provide handlers for resources with same names but from different packages. Hence, we should use apiGroup name in packages in order to segregate handlers/operations classes as per their respective apiGroup
manusa
force-pushed
the
pr/openshift-client-handlers-apigroups
branch
from
c10af9a
to
16d7e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now all OpenShiftClient's Handler/OperationsImpl classes get
generated in one package
io.fabric8.openshift.client.handlers/io.fabric8.openshift.client.dsl.internalThis creates problems if we want to provide handlers for resources with
same names but from different packages. Hence, we should use apiGroup
name in packages in order to segregate handlers/operations classes as
per their respective apiGroup
Related to #2949
Type of change
test, version modification, documentation, etc.)
Checklist