Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tekton-triggers] update to v0.13.0 #3099

Merged
merged 3 commits into from
May 12, 2021
Merged

[tekton-triggers] update to v0.13.0 #3099

merged 3 commits into from
May 12, 2021

Conversation

Fabian-K
Copy link
Contributor

Description

This PR updates the model of tekton triggers to 0.13.0. It does not solve the *FluentImpl issue mentioned in #2916 but it addresses the Interceptor related changes which are part of 0.13.0.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@rohanKanojia
Copy link
Member

We just disabled the flaky crd generator test in #3103 . Could you please rebase your branch against master?

@manusa manusa mentioned this pull request May 12, 2021
Closed
11 tasks
@manusa manusa mentioned this pull request May 12, 2021
Merged
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

manusa
manusa approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 7bda497 into fabric8io:master May 12, 2021
ddl-audi pushed a commit to ddl-audi/kubernetes-client that referenced this pull request May 14, 2021
@Fabian-K @ddl-audi
[tekton-triggers] update to v0.13.0 (fabric8io#3099)
199e456 
* [tekton-triggers] update to v0.13.0

* [tekton-triggers] revert changes within generator in favor of manualTypeMap

* [tekton-triggers] remove unnecessary new line 🤦‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fabian-K @centos-ci @rohanKanojia @manusa @oscerd