fixing #3001 #3186 over logging of websocket exceptions and closure #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Jun 1, 2021
shawkins
force-pushed
the
watch_close
branch
3 times, most recently
from
22d7041
to
3ddf258
Compare
|
This should wait until after #3185 - it looks like after that change a lot more logic can be pulled up into AbstractWatchManager. I have started down that path with this pr. |
shawkins
force-pushed
the
watch_close
branch
4 times, most recently
from
a635096
to
93da37b
Compare
…ions and closure this removes the runner abstraction it also replaces the use of BlockingQueue with CompletableFuture.
rohanKanojia
approved these changes
Jun 9, 2021
manusa
reviewed
Jun 9, 2021
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/Utils.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
This was referenced Jun 9, 2021
Vlatombe
added a commit
to Vlatombe/kubernetes-plugin
that referenced
this pull request
Mar 31, 2022
InterruptedException is no longer thrown on websocket timeout, rather a KubernetesClientException. Unfortunately there is no way to differentiate between a timeout and an error. * fabric8io/kubernetes-client#3274 * fabric8io/kubernetes-client#3197
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this localizes the state of a websocket to the listener, rather than the runner, to have a clearer lifecycle.
it reduces the logging of websocket stacktraces that shouldn't be meaningful.
it also replaces the use of BlockingQueue with CompletableFuture and adds another version of the utility method waitUntilReady for callers you aren't checking the boolean value.
Type of change
test, version modification, documentation, etc.)
Checklist