Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chaos-mesh extension to v1.2.3. Add AwsChaos #3380

Merged
merged 1 commit into from Aug 11, 2021
Merged

Update chaos-mesh extension to v1.2.3. Add AwsChaos #3380

merged 1 commit into from Aug 11, 2021

Conversation

hypnoce
Copy link
Contributor

@hypnoce hypnoce commented Aug 4, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@hypnoce
Copy link
Contributor Author

hypnoce commented Aug 5, 2021

Java 8 build passed locally on my side, not sure why the CI is failing.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

manusa
manusa approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 5.7.0 milestone Aug 11, 2021
@manusa manusa merged commit 6269a04 into fabric8io:master Aug 11, 2021
@manusa manusa added changelog missing A line to changelog.md regarding the change is not added and removed changelog missing A line to changelog.md regarding the change is not added labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@shawkins shawkins Awaiting requested review from shawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hypnoce @centos-ci @manusa @rohanKanojia