Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateStatus() to no longer work as with mock server in CRUD mode #3383 #3385

Closed
wants to merge 1 commit into from

Conversation

gdauchet
Copy link

@gdauchet gdauchet commented Aug 6, 2021

…from 5.0.2, causing updateStatus() to no longer work as with mock server in CRUD mode as it generates a JSON_MERGE_PATCH patch type which is not handled. Added the implementation to handle this patch type.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

…from 5.0.2, causing updateStatus() to no longer work as with mock server in CRUD mode as it generates a JSON_MERGE_PATCH patch type which is not handled. Added the implementation to handle this patch type.
@centos-ci
Copy link

Can one of the admins verify this patch?

@shawkins
Copy link
Contributor

shawkins commented Aug 6, 2021

These aren't the right changes to address #3383 and #3379 - the change needed is to replace patchStatus calls in RawCustomResourceOperationsImpl with updateStatus calls -

.patchStatus(Serialization.jsonMapper().convertValue(objectAsMap, GenericKubernetesResource.class)));

This is more of a separate feature to implement mock handling of merge patches.

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants