Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add KubernetesMockServer accessor to JUnit4 KubernetesServer rules #3583

Merged
merged 1 commit into from Nov 12, 2021
Merged

fix: Add KubernetesMockServer accessor to JUnit4 KubernetesServer rules #3583

merged 1 commit into from Nov 12, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented Nov 11, 2021 •
edited

Description

fix: Add KubernetesMockServer accessor to JUnit4 KubernetesServer rules

Related to: quarkusio/quarkus#21362

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 5.10.1 milestone Nov 11, 2021
@centos-ci
Copy link

Can one of the admins verify this patch?

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 7b115b1 into fabric8io:master Nov 12, 2021
@manusa manusa deleted the fix/junit4-kubernetes-server branch November 12, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@shawkins shawkins Awaiting requested review from shawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.10.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manusa @centos-ci @oscerd @rohanKanojia