Fix #3568: Pod upload file fails if file is directly in root path #3719

rohanKanojia · 2022-01-06T16:40:01Z

Description

Pod file upload seems be be creating invalid exec command for upload if
the file is directly in root path e.g. /cp.log. We create parent
directory of file by creating a substring based on last index of /.
This returns an empty string for a string like /cp.log.

Assume directory path to be / when directory is returned as empty string.

Signed-off-by: Rohan Kumar rohaan@redhat.com

Type of change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change
Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

Code contributed by me aligns with current project license: Apache 2.0
I Added CHANGELOG entry regarding this change
I have implemented unit tests to cover my changes
I have added/updated the javadocs and other documentation accordingly
No new bugs, code smells, etc. in SonarCloud report
I tested my code in Kubernetes
I tested my code in OpenShift

manusa

LGTM, thx!

… path Pod file upload seems be be creating invalid exec command for upload if the file is directly in root path e.g. `/cp.log`. We create parent directory of file by creating a substring based on last index of `/`. This returns an empty string for a string like `/cp.log`. Assume directory path to be `/` when directory is returned as empty string. Signed-off-by: Rohan Kumar <rohaan@redhat.com>