fix (kubernetes-client) : edit(), patch() and other mutating operations shouldn't be allowed in NonNamespaceOperation (#3772)

[rohanKanojia]

Description

Fix #3772

Remove reference to WritableOperation<T> interface from
NonNamespaceOperation as it exposes edit(), patch() and other
mutating operations.

Signed-off-by: Rohan Kumar rohaan@redhat.com

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[shawkins]

@rohanKanojia @manusa One small possibility is to allow the methods that pass in an object to not require withName as it can be inferred.

[manusa]

I created the issue for the edit and patch methods.

I assume that the PR just reverted the interface implementation to what it was before introducing the issue, right @rohanKanojia?

One small possibility is to allow the methods that pass in an object to not require withName as it can be inferred.

Yes. IIRC this was already possible before this PR was merged, so just adding the interfaces would be enough.

[rohanKanojia]

I think these edit, patch interfaces were not part of NonNamespaceOperation before 5.2.0 . They were added by me during dry run implementation

https://github.com/fabric8io/kubernetes-client/blob/v5.1.0/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/NonNamespaceOperation.java

[manusa]

I was asking namely about replace. I understand that this one supports being called without withName.

[rohanKanojia]

I'm not able to find replace available in NonNamespaceOperation in v5.1.0

[manusa]

This was introduced in the mentioned PR (#2832). However, this operation IIRC should work, since the name can be inferred from the resource.

In the current PR, you removed this. I'm assuming because of this. The issue only mentioned patch/edit, I only merged the PR because I was assuming this was the prior behavior.

So, as Steven suggested, this operation (I wouldn't do this for patch, only for replace) could be added back. And if I'm not mistaken, for the replace implementation, we already have the logic to retrieve the name, so it should be as simple as adding the interface in the right place.

Does this sound clearer now?