Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chaos mesh to v2.1.3 #3967

Merged
merged 3 commits into from Aug 30, 2022
Merged

Update chaos mesh to v2.1.3 #3967

merged 3 commits into from Aug 30, 2022

Conversation

hypnoce
Copy link
Contributor

@hypnoce hypnoce commented Mar 14, 2022 •
edited by rohanKanojia

Description

  • Update chaos mesh to v2.1.3
  • JVMChaosSpec, JVMLatencySpec, JVMReturnSpec, JVMExceptionSpec classes
    contain a string field with name class which causes problems with
    sundrio processing.
    Maintain a hand written version of these classes which will use a
    different variable name but keep property name preserved in
    Jackson's @JsonProperty annotation
  • Some go structs have been renamed in newer version of ChaosMesh model. These are:
    • AwsChaos => AWSChaos
    • IoChaos => IOChaos
    • PodIoChaos => PodIOChaos
  • Scheduler field has been removed from IOChaosSpec
  • Force protobuf and yaml.v2 dependencies to not use vulnerable versions (Fix Dependabot reported alerts in go modules #4327)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@hypnoce
Copy link
Contributor Author

hypnoce commented Mar 14, 2022 •
edited

@iocanel I intentionally left this PR breaking the build. The problem is that one of the fields in the chaosmesh CRD has the name "class". While this works fine with jsonchema2pojo (rename to _class, getClass_ and setClass_), it breaks sundr. There are many ways to fix this, I wanted to get your feedback first.

@hypnoce
Copy link
Contributor Author

hypnoce commented Mar 23, 2022

@oscerd @iocanel let me know how you prefer to move forward with this. Thanks

@manusa
Copy link
Member

manusa commented Jul 28, 2022

Hi @hypnoce
This PR never made it to the ready phase and is now quite updated. Are you still working on it?

@rohanKanojia rohanKanojia self-assigned this Aug 25, 2022
@rohanKanojia rohanKanojia force-pushed the update_chaosmesh branch 5 times, most recently from 531e99b to 9df6140 Compare August 26, 2022 10:06
@manusa manusa marked this pull request as ready for review August 29, 2022 07:39
manusa
manusa reviewed Aug 29, 2022
View reviewed changes
CHANGELOG.md
@@ -23,6 +23,7 @@

#### Dependency Upgrade
* Bump Knative model to v0.34.0
* Update chaos-mesh extension to v2.1.3. Add PodHttpChaos, GCPChaos, BlockChaos and PhysicalMachineChaos.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the capitalization of some generated class names has changed. We should add a note about this or revert this change.

@manusa manusa added this to the 6.1.0 milestone Aug 29, 2022
@manusa
Copy link
Member

manusa commented Aug 29, 2022

After #4358, the fix (extensions/chaosmesh) : Use hand written JVMChaosSpec and related classes should not be necessary.
Please rebase and remove it.

manusa
manusa requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

hypnoce and others added 3 commits August 29, 2022 19:59
@hypnoce @rohanKanojia
Update chaos mesh to v2.1.3
e43060e
@rohanKanojia
fix (extensions/chaosmesh) : Accomodate breaking changes from ChaosMe…
c584a1f 
…sh model

+ Some go structs have been renamed in newer version of ChaosMesh model. These are:
  - AwsChaos => AWSChaos
  - IoChaos  => IOChaos
  - PodIoChaos => PodIOChaos
+ Scheduler field has been removed from IOChaosSpec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
fix (extensions/chaosmesh) : Force protobuf and yaml.v2 dependencies …
796111a 
…to not use vulnerable versions (fabric8io#4327)

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 22f0dcb into fabric8io:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hypnoce @manusa @oscerd @rohanKanojia