Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing unit test testSerializeYamlWithAlias. #4485

Merged
merged 1 commit into from Nov 4, 2022
Merged

Fixed failing unit test testSerializeYamlWithAlias. #4485

merged 1 commit into from Nov 4, 2022

Conversation

DobromirM
Copy link
Contributor

@DobromirM DobromirM commented Oct 7, 2022

Description

Fixes #4484

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@DobromirM
Copy link
Contributor Author

Fixes #4484

@andreaTP andreaTP added the Waiting on feedback Issues that require feedback from User/Other community members label Oct 10, 2022
@andreaTP
Copy link
Member

the test is correctly passing in CI, we need to understand if there is a real issue here.

@DobromirM
Copy link
Contributor Author

It seems that the test fails only when running with Oracle OpenJDK, switching my local SDK to Eclipse Temurin to match the CI has resolved the problem.

Might be a good idea to add that as a note in CONTRIBUTING.md

@andreaTP
Copy link
Member

cc. @manusa @rohanKanojia

@rohanKanojia
Copy link
Member

@DobromirM : Which version of Oracle JDK are you using? I ran on JDK11 and it seems to be passing for me.

In my opinion it's okay to merge this PR if it fixes issue on both JDKs.

@DobromirM
Copy link
Contributor Author

It was failing on my side with both JDK11 and the bundled JDK11 that comes with IntelliJ. https://github.com/JetBrains/JetBrainsRuntime

@shawkins
Copy link
Contributor

Can confirm the test failure when using OpenJDK 17 as well.

@shawkins
Copy link
Contributor

@DobromirM did you mean to close this pr?

@DobromirM DobromirM reopened this Oct 27, 2022
@DobromirM
Copy link
Contributor Author

@DobromirM did you mean to close this pr?

Sorry, my bad.

@shawkins shawkins removed the Waiting on feedback Issues that require feedback from User/Other community members label Oct 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa manusa added this to the 6.3.0 milestone Nov 4, 2022
@manusa manusa merged commit c502dde into fabric8io:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSerializeYamlWithAlias failing
5 participants