Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3906: removing BaseKubernetesList #4499

Merged
merged 2 commits into from Oct 19, 2022
Merged

fix #3906: removing BaseKubernetesList #4499

merged 2 commits into from Oct 19, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 14, 2022 •
edited by manusa

Description

This seems to be the easiest conclusion to #3906 - to remove BaseKubernetesList and reuse the DefaultKubernetesResourceList implementation for KuberenetesList. BaseKubernetesList was only introduced in the first place to implement item sorting. Ideally no-one should have been directly using that class, but it was left as public so it could be deprecated instead of removed if desired.

That leaves us with the KubernetesResourceList interface, the generic DefaultKubernetesResourceList, and a HasMetadata implementation KuberenetesList.

Closes #3906

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

manusa
manusa approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 6.2.0 milestone Oct 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit e04de76 into fabric8io:master Oct 19, 2022
@manusa manusa mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

Rationalize KubernetesList/BaseKubernetesList/DefaultKubernetesResourceList
2 participants
@shawkins @manusa