fix: Stack overflow on multi maps (and other non-trivial generic clas… #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
It seems that sundrio 0.93.1 is not yet fully released. I will make it Ready for review once it is. |
xRodney
force-pushed
the
bugfix/multi-maps4
branch
2 times, most recently
from
f8acda3
to
bf5df02
Compare
|
Sundrio has been released (thanks @iocanel), this is now ready for review. |
xRodney
force-pushed
the
bugfix/multi-maps4
branch
from
bf5df02
to
ba34cec
Compare
andreaTP
reviewed
Oct 18, 2022
crd-generator/api/src/test/java/io/fabric8/crd/example/map/ContainingMapsSpec.java
Outdated
Show resolved
Hide resolved
xRodney
force-pushed
the
bugfix/multi-maps4
branch
from
ba34cec
to
9bf6fc2
Compare
manusa
reviewed
Oct 19, 2022
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
|
|
||
| class ContainingMapsCRDTest { |
There was a problem hiding this comment.
Most of these tests could be refactored to use single assertions with AssertJ, but it's not big deal
There was a problem hiding this comment.
OK, this is probably a port of CRDGeneratorTest. That one needs some refactoring too 😅
…es), schema for multimaps is wrong Logic in sundrio that is responsible for replacing generic type arguments on methods and properties with their concrete instantiations from subclasses contained a bug, in which it looped infinitely if the same type argument name was used at multiple classes in the hierarchy. A common occurence were multimaps. A very similar code was also present in crd-generator, also suffering from the same bug. Sundrio has been updated to account for this situation, and updated utilities from sundrio have been introduced to crd-generator, which replace the previous implementation of the same algorithm. A test has been added to validate that multimaps (like `class MultiMap<K,V> implements Map<K,List<V>>`) are generated correctly. Fixes fabric8io#4357 Fixes fabric8io#4487
manusa
force-pushed
the
bugfix/multi-maps4
branch
from
9bf6fc2
to
0156d0f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
…ses), schema for multimaps is wrong
Logic in sundrio that is responsible for replacing generic type arguments on methods and properties with their concrete instantiations from subclasses contained a bug, in which it looped infinitely if the same type argument name was used at multiple classes in the hierarchy. A common occurence were multimaps.
A very similar code was also present in crd-generator, also suffering from the same bug.
Sundrio has been updated to account for this situation, and updated utilities from sundrio have been introduced to crd-generator, which replace the previous implementation of the same algorithm.
A test has been added to validate that multimaps (like
class MultiMap<K,V> implements Map<K,List<V>>) are generated correctly.Fixes #4357
Fixes #4487
Supersedes closes #4504
Type of change
test, version modification, documentation, etc.)
Checklist