Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4535 - support file uploads with filenames containing single quote #4538

Merged
merged 1 commit into from
Nov 4, 2022

Commits on Nov 4, 2022

  1. fix: shell command string will now have single quotes sanitized

    Single quotes in folder or file names were causing corruption of the shell command.
    The fix changes the ' character to '"'"'
    For example a folder called te'st would now get shellQuoted to 'te'"'"'st'
    1. ' ends the first quote,
    2. " starts second quote,
    3. ' is valid character in double quotes
    4. " ends the second quote
    5. ' starts the third quote
    6. The end result when fed into the shell, is as we desired: te'st
    
    fabric8io#4535
    
    iss-4535
    
    Changed to be much shorter as pointed out, manual still passes tests.
    New test added
    Changelog moved.
    
    iss-4535
    
    Fixed test brackets that mvn spotless:apply unfortunately didn't.
    
    fabric8io#4535
    
    iss-4535
    
    Altered some catch statements to catch exceptions rather than throwables for sonar
    
    fabric8io#4535
    BrianDevC authored and manusa committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3105c42 View commit details
    Browse the repository at this point in the history