Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4547: preventing a cancelled leader elector #4548

Merged
merged 1 commit into from Nov 4, 2022
Merged

fix #4547: preventing a cancelled leader elector #4548

merged 1 commit into from Nov 4, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 31, 2022 •
edited by manusa

Description

Fixes #4547 by synchronizing the cancel and renew methods

cc @csviri

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins requested a review from manusa October 31, 2022 19:09
csviri
csviri approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@csviri csviri mentioned this pull request Nov 1, 2022
Closed
@manusa manusa added this to the 6.3.0 milestone Nov 4, 2022
@manusa manusa merged commit baae908 into fabric8io:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@csviri csviri csviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Timing issue with leader elector cancel (stop)
3 participants
@shawkins @manusa @csviri