Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4569: accounting for 0 timeouts that are not supported by jdk #4570

Merged
merged 1 commit into from Nov 15, 2022
Merged

fix #4569: accounting for 0 timeouts that are not supported by jdk #4570

merged 1 commit into from Nov 15, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Nov 8, 2022 •
edited by manusa

Description

Fix #4569 - the regression from #4490. We need more pervasive checks in the jdk client for the 0 (no) timeout value.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.6% 70.6% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 4ac5137 into fabric8io:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fabric8 builds JdkHttpClientImpl with 0 as timeout, and that leads to "Invalid duration: PT0S"
2 participants
@shawkins @manusa