Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (kubernetes-model-generator) : Upgrade Fabric8 Kubernetes Model to Kubernetes v1.26.0 (#4655) #4731

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jan 4, 2023

Description

Fix #4655 #4804

  • Upgrade Fabric8 Kubernetes Model to Kubernetes v1.26.0
  • Add Kubernetes 1.26.0 to Kubernetes E2E tests matrix
    • Add Kubernetes 1.26.0 to Kubernetes E2E tests matrix
    • Set Driver=docker and container-runtime=containerd in minikube GitHub
      action in order to run Kubernetes 1.26
  • Update Kubernetes Model GatewayApi to v0.6.0 (The attribute of ‘responseHeaderModifier’ is not in class named io.fabric8.kubernetes.api.model.gatewayapi.v1beta1.HTTPRouteFilter #4804)
    • gateway.networking.k8s.io/v1alpha2 ReferencePolicy struct removed from kubernetes-model-gatewayapi in favor of
      ReferenceGrant
    • Updating Kubernetes Model Gateway breaks build for cert-manager extension. It also needs to be updated to the latest version which uses latest sigs.k8s.io/gateway-api dependency

New Resources

  • Add admissionregistration.k8s.io/v1alpha1
    • ValidatingAdmissionPolicy
    • ValidatingAdmissionPolicyBinding
  • Add flowcontrol.apiserver.k8s.io/v1beta3
    • FlowSchema
    • PriorityLevelConfiguration
  • Add authentication.k8s.io/v1alpha1
    • SelfSubjectReview
  • Add new module kubernetes-model-resource for
    resource.k8s.io/v1alpha1 apiGroup.
    • ResourceClaimTemplate
    • ResourceClaim
    • ResourceClass
    • PodScheduling

Other Changes

  • New field ordinals of type StatefulSetOrdinals added to StatefulSetSpec
  • PersistentVolumeClaimSpec's dataSourceRef changed from TypedLocalObjectReference -> TypedObjectReference
  • New list fields resourceClaims and schedulingGates of type PodResourceClaim and PodSchedulingGate added to PodSpec
  • New list field claims of type ResourceClaim added to ResourceRequirements
  • IngressStatus's loadBalancer field type changed from LoadBalancerStatus -> IngressLoadBalancerStatus
  • New field unhealthyPodEvictionPolicy added to PodDisruptionBudgetSpec

Signed-off-by: Rohan Kumar rohaan@redhat.com

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Feb 1, 2023

Comparing with OpenAPI generation results.
The following new APIs are available:

  • admissionregistration.k8s.io/v1alpha1
  • authentication.k8s.io/v1alpha1
  • flowcontrol.apiserver.k8s.io/v1beta3
  • resource.k8s.io/v1alpha1

I see you added DSL for FlowControl and AdmissionRegistration, but can't see the other two.

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… to Kubernetes v1.26 (fabric8io#4655)

+ Upgrade Fabric8 Kubernetes Model to Kubernetes v1.26.0
+ Add `admissionregistration.k8s.io/v1alpha1` ValidatingAdmissionPolicy
  and ValidatingAdmissionPolicyBinding resources
+ Add `authentication.k8s.io/v1alpha1` SelfSubjectReview
+ Add new module `kubernetes-model-resource` for
  `resource.k8s.io/v1alpha1` apiGroup
+ Add `flowcontrol.apiserver.k8s.io/v1beta3` FlowSchema and PriorityLevelConfiguration

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
+ Add Kubernetes 1.26.0 to Kubernetes E2E tests matrix
+ Set Driver=docker and container-runtime=containerd in minikube GitHub
  action in order to run Kubernetes 1.26

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…Api to v0.6.0 (fabric8io#4804)

+ Update `sigs.k8s.io/gateway-api` dependency to v0.6.0
+ v1alpha2 ReferencePolicy struct removed from model in favor of
  ReferenceGrant

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Updating Kubernetes Model Gateway breaks build for certmanager. It also
needs to be updated to latest version which uses latest
`sigs.k8s.io/gateway-api` dependency

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

35.0% 35.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.5 milestone Feb 6, 2023
@manusa manusa merged commit 50a4fc5 into fabric8io:master Feb 6, 2023
@rohanKanojia rohanKanojia deleted the pr/issue4655 branch February 6, 2023 11:35
@manusa manusa removed this from the 6.5 milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants