Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: @KubernetesTest annotation can be used in base test classes #4734

Merged
merged 2 commits into from
Jan 10, 2023
Merged

feat: @KubernetesTest annotation can be used in base test classes #4734

merged 2 commits into from
Jan 10, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 5, 2023 •
edited
Loading

Description

feat: @KubernetesTest annotation can be used in base test classes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
feat: @KubernetesTest annotation can be used in base test classes
c934dc6 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the feat/kubernetes-test branch 3 times, most recently from 40fa963 to 7ec36fd Compare January 5, 2023 12:04
shawkins
shawkins approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa force-pushed the feat/kubernetes-test branch 3 times, most recently from 99e940b to e772c28 Compare January 10, 2023 09:32
@manusa
feat: @KubernetesTest/KubernetesNamespacedTestExtension creates an ep…
5ba4ba1 
…hemeral Namespace optionally (can opt-out)

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

73.8% 73.8% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 7d03c3a into fabric8io:master Jan 10, 2023
@manusa manusa deleted the feat/kubernetes-test branch January 10, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawkins shawkins shawkins approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manusa @shawkins @rohanKanojia