Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print warning message when service account token property is unset #4795

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Don't print warning message when service account token property is unset #4795

merged 1 commit into from
Jan 30, 2023

Conversation

Sgitario
Copy link
Contributor

Description

Trace the warning message if the user has set the service account token system property. Otherwise, simply print a debug message if there is no file in the default location.

Relates quarkusio/quarkus#30558

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift
  • I tested my code locally

@Sgitario Sgitario mentioned this pull request Jan 26, 2023
Closed
@Sgitario
Copy link
Contributor Author

@manusa this pull request relates to quarkusio/quarkus#30558.
Maybe we can clarify what you meant in quarkusio/quarkus#30558 (comment) and continue the discussion here.

Feel free to reject/close this pull request if you consider I'm completely wrong :)

@Sgitario
Don't print warning message when service account token property is unset
ecef75c 
Trace the warning message if the user has set the service account token system property. Otherwise, simply print a debug message if there is no file in the default location. 

Relates quarkusio/quarkus#30558
@manusa
Copy link
Member

manusa commented Jan 26, 2023

@manusa this pull request relates to quarkusio/quarkus#30558. Maybe we can clarify what you meant in quarkusio/quarkus#30558 (comment) and continue the discussion here.

Feel free to reject/close this pull request if you consider I'm completely wrong :)

Haven't checked deeply but overall seems fine.

Maybe we can clarify what you meant in quarkusio/quarkus#30558 (comment) and continue the discussion here.

My comment has a different scope and is more of a reflection about how configuration inference works.

shawkins
shawkins approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.5.0 milestone Jan 30, 2023
@manusa manusa merged commit 62ee93c into fabric8io:master Jan 30, 2023
manusa pushed a commit that referenced this pull request Jan 30, 2023
chore: add missing changelog entry for #4795
80bff08 
Signed-off-by: GitHub <bot@example.com>
@manusa manusa modified the milestones: 6.5.0, 6.4.1 Jan 31, 2023
manusa pushed a commit that referenced this pull request Jan 31, 2023
chore: add missing changelog entry for #4795
07014fb 
Signed-off-by: GitHub <bot@example.com>

(cherry picked from commit 80bff08)
Signed-off-by: GitHub <bot@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@shawkins shawkins shawkins approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sgitario @manusa @shawkins @rohanKanojia