Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: VertxHttpClientBuilder is public #4809

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 30, 2023

Description

refactor: VertxHttpClientBuilder is public

Make VertxHttpClientBuilder a top-level class to be able to create a Quarkus-specific HttpClient.Factory and reuse it.

Relates to quarkusio/quarkus#30480

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Signed-off-by: GitHub <bot@example.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

81.5% 81.5% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member Author

manusa commented Jan 30, 2023

Hi @shawkins,
I need this to be able to create a Quarkus-specific HttpClient.Factory where I can pass its Vertx object. These changes allow me to reuse the builder and the client implementation.
There's nothing fancy here, just moving the affected classes top level and making the builder constructor public.

@manusa manusa added this to the 6.4.1 milestone Jan 30, 2023
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa merged commit 55357e1 into fabric8io:6.4 Jan 31, 2023
@manusa manusa deleted the refactor/vertx-client branch January 31, 2023 05:53
@manusa manusa self-assigned this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants