Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate zjsonpatch version property declaration. #5563

Merged
merged 1 commit into from Nov 2, 2023

Conversation

SamBarker
Copy link
Contributor

Description

With the mock web server migrated into this repo zjsonpatch is now a production rather than test dependency.

The duplicate property definition has the potential to cause issues for tools which process the pom even if the kubernetetes-client build itself is un-affected (as both properties defined the same version).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

With the mock web server migrated into this repo zjsonpatch is now a production rather than test dependency.
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thx

@manusa manusa added this to the 6.9.2 milestone Nov 2, 2023
@SamBarker
Copy link
Contributor Author

I don't really see the need for a change log entry, would it add any value?

@SamBarker SamBarker marked this pull request as ready for review November 2, 2023 09:27
@manusa
Copy link
Member

manusa commented Nov 2, 2023

I don't really see the need for a change log entry, would it add any value?

No, just mark it as ready if you don't want to change anything else. It should be good to go.

@manusa manusa merged commit 0e7c61a into fabric8io:main Nov 2, 2023
19 of 20 checks passed
@SamBarker SamBarker deleted the duplicate-zjsonpatch branch November 2, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants