Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (kubernetes-client-api) : Add DSL for flowcontrol.apiserver.k8s.io v1 apiVersion #5688

Merged

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jan 4, 2024

Description

Related to #5643

Add the following DSL entrypoints for KubernetesClient:

  • client.flowControl().v1().priorityLevelConfigurations()
  • client.flowControl().v1().flowSchema()

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/issue5643-kubernetes-client-dsl branch from 8387946 to 1900341 Compare January 8, 2024 15:03
@rohanKanojia rohanKanojia marked this pull request as ready for review January 8, 2024 16:31
@manusa manusa added this to the 6.10.0 milestone Jan 8, 2024
….io` `v1` apiVersion

Add the following DSL entrypoints for KubernetesClient:
- `client.flowControl().v1().priorityLevelConfigurations()`
- `client.flowControl().v1().flowSchema()`

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia force-pushed the pr/issue5643-kubernetes-client-dsl branch from 1900341 to d03b837 Compare January 8, 2024 17:43
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@manusa manusa merged commit 1d23d2b into fabric8io:main Jan 9, 2024
16 of 19 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue5643-kubernetes-client-dsl branch January 9, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants