Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps (kubernetes-model-gatewayapi) : Bump sigs.k8s.io/gateway-api to 1.0.0 #5691

Merged
merged 2 commits into from Jan 9, 2024

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jan 8, 2024

Description

Fix #5673

certmanager extension depends on this kubernetes-model-gatewayapi, I had to bump certmanager extension to latest version as well

  • Bump sigs.k8s.io/gateway-api go dependency to v1.0.0
  • Bumpgenerator-v1 model github.com/cert-manager/cert-manager to latest available version (v1.14.0-alpha.0.0.20240105200543-3234974a3865)
  • Add new resources to Kubernetes GatewayAPI model
    • gateway.networking.k8s.io/v1 Gateway
    • gateway.networking.k8s.io/v1 GatewayClass
    • gateway.networking.k8s.io/v1 HTTPRoute
    • gateway.networking.k8s.io/v1alpha2 BackendTLSPolicy

Most files are modified due to package changes. Gateway Model seems to be using types across versions (i.e v1beta1, v1alpha2 objects relying on v1 types)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/issue5673 branch 4 times, most recently from b494bb8 to 885781c Compare January 9, 2024 05:43
…o `1.0.0`

+ Bump `sigs.k8s.io/gateway-api` go dependency to v1.0.0
+ Add v1 Gateway, GatewayClass and HTTPRoute resources to Kubernetes
  GatewayAPI model

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
`v1.14.0-alpha.0.0.20240105200543-3234974a3865`

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rohanKanojia rohanKanojia marked this pull request as ready for review January 9, 2024 07:24
@manusa manusa added this to the 6.10.0 milestone Jan 9, 2024
@manusa manusa merged commit 4d4daa8 into fabric8io:main Jan 9, 2024
17 of 19 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue5673 branch January 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The v1 Version gateway-api not yet supported
3 participants