Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: owner reference validity check regarding scope and namespace #5701

Merged
merged 6 commits into from Jan 17, 2024
Merged

feat: owner reference validity check regarding scope and namespace #5701

merged 6 commits into from Jan 17, 2024

Conversation

csviri
Copy link
Contributor

@csviri csviri commented Jan 10, 2024 •
edited

Description

Checks is owner references are correct in terms of scope and namespaces:

  1. The referenced object should not be from different namespace (if both are namespaced objects)
  2. Cluster scoped object should not reference namespace scoped object

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@csviri csviri changed the title Owner reference check fix: owner reference validity check regarding scope and namespace Jan 10, 2024
@csviri csviri marked this pull request as ready for review January 10, 2024 10:32
@csviri csviri changed the title fix: owner reference validity check regarding scope and namespace feat: owner reference validity check regarding scope and namespace Jan 10, 2024
@manusa manusa self-assigned this Jan 17, 2024
csviri and others added 6 commits January 17, 2024 06:26
@csviri @manusa
feat: check if owner reference validity regarding namespace scope
188ab77 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @manusa
add unit test
b47600b 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @manusa
changelog
0319c59 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @rohanKanojia @manusa
Update kubernetes-model-generator/kubernetes-model-core/src/main/java…
9435200 
…/io/fabric8/kubernetes/api/model/HasMetadata.java

Co-authored-by: Rohan Kumar  <rohan.kumar.kanojia@gmail.com>
@manusa
fix: typo
665147f
@manusa
chore: move changelog entry to snapshot
88cea1e
manusa
manusa approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa removed their assignment Jan 17, 2024
@manusa manusa added this to the 6.11.0 milestone Jan 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa merged commit 0115f41 into fabric8io:main Jan 17, 2024
17 of 19 checks passed
@csviri csviri mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

@sunix sunix Awaiting requested review from sunix sunix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csviri @manusa @oscerd @rohanKanojia