Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 for basic authentication #5789

Merged
merged 3 commits into from Mar 22, 2024
Merged

Use UTF-8 for basic authentication #5789

merged 3 commits into from Mar 22, 2024

Conversation

jpraet
Copy link
Contributor

@jpraet jpraet commented Mar 11, 2024

Description

Use UTF-8 for basic authentication. Fixes #5781.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

Is this PR ready to merge (still marked as Draft)? If so, please mark it as ready and post a comment so I get notified 😅

@manusa manusa added this to the 6.11.0 milestone Mar 12, 2024
@jpraet jpraet marked this pull request as ready for review March 12, 2024 06:27
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jpraet

Copy link

sonarcloud bot commented Mar 21, 2024

@manusa manusa merged commit 5764b31 into fabric8io:main Mar 22, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic authentication fails with special characters in password
6 participants