Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store file with Git #5806

Merged
merged 1 commit into from Mar 25, 2024
Merged

Conversation

zwangsheng
Copy link
Contributor

@zwangsheng zwangsheng commented Mar 14, 2024

Description

.DS_Store, short for Desktop Services Store, is a hidden file created by MacOS to store custom attributes of a folder, such as the positions of icons or the choice of a background image. Whenever you open a folder using Finder, MacOS generates this file to remember your view settings for that particular folder.

When developers work on MacOs, they may find those .DS_Store file are track by git.

It's best practice for us to ignore this file with git.

Close #5805

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@zwangsheng
Copy link
Contributor Author

Test in local:

Before this PR:

截屏2024-03-14 10 18 16

After this PR:

截屏2024-03-14 10 19 17

Thanks, if you have any doubts or questions, please let me know.

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@manusa manusa added this to the 6.11.0 milestone Mar 25, 2024
@manusa manusa merged commit ddcba82 into fabric8io:main Mar 25, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce .DS_Store to .gitignore
3 participants