added coment and extract dropTarget variable

fabricjs · Jan 15, 2023 · 3dd25c2 · 3dd25c2
1 parent c0fa8fb
commit 3dd25c2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/canvas/canvas_events.ts b/src/canvas/canvas_events.ts
@@ -337,12 +337,13 @@ export class Canvas extends SelectableCanvas {
   ) {
     let dirty = false;
     // clear top context
+    const dropTarget = this._dropTarget;
     if (
-      this._dropTarget &&
-      this._dropTarget !== source &&
-      this._dropTarget !== target
+      dropTarget &&
+      dropTarget !== source &&
+      dropTarget !== target
     ) {
-      this._dropTarget.clearContextTop();
+      dropTarget.clearContextTop();
       dirty = true;
     }
     source?.clearContextTop();

diff --git a/src/mixins/itext_click_behavior.mixin.ts b/src/mixins/itext_click_behavior.mixin.ts
@@ -195,6 +195,9 @@ export abstract class ITextClickBehaviorMixin<
       return;
     }
 
+    // mousedown is going to early return if isDragging is true.
+    // this is here to recover the setCursorByClick in case the
+    // isDragging is a false positive.
     shouldSetCursor && this.setCursorByClick(options.e);
 
     if (this.__lastSelected && !this.__corner) {