Skip to content

Commit

Permalink
ci(): Add node18 and add a check for prettier (#8275)
Browse files Browse the repository at this point in the history
  • Loading branch information
asturur committed Sep 11, 2022
1 parent 5abd101 commit 938033a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# This workflow will install Uglify and verify that fabric can be build with it

name: '🩺'

on:
Expand Down Expand Up @@ -27,7 +25,18 @@ jobs:
node-version: 16.x
- run: npm ci
- run: npm run lint
prettier:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Prettier check
uses: actions/setup-node@v1
with:
node-version: 16.x
- run: npm ci
- run: npm run prettier:check
coverage:
if: ${{ always() }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
# supported Node.js release schedule: https://nodejs.org/en/about/releases/
node-version: [14.x, 16.x]
node-version: [14.x, 16.x, 18.x]
suite: [unit, visual]
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"lint": "eslint --config .eslintrc.js src/**/*.ts",
"lint_tests": "eslint test/unit --config .eslintrc_tests && eslint test/visual --config .eslintrc_tests",
"all": "npm run build && npm run test -- --all && npm run lint && npm run lint_tests && npm run export",
"prettier:check": "prettier --check",
"prettier:check": "prettier --check .",
"prettier:write": "prettier --write ."
},
"optionalDependencies": {
Expand Down

0 comments on commit 938033a

Please sign in to comment.