Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images aren't resizable in IE8 #5

Closed
weepy opened this issue Oct 11, 2010 · 18 comments
Closed

Images aren't resizable in IE8 #5

weepy opened this issue Oct 11, 2010 · 18 comments
Labels

Comments

@weepy
Copy link

weepy commented Oct 11, 2010

Specifically IE8

@polarblau
Copy link

fabric.js looks really awesome, but not being able to scale or move images in IE7/8 would be pretty much a show stopper for me. Are there any forks or work–arounds existing which tackle this problem? Cheers!

@kangax
Copy link
Member

kangax commented Mar 28, 2011

Not that I know of :(

The problem is that fabric relies on excanvas in non-canvas-capable (but VML-capable) browsers like IE7 or 8.

Last time I looked into this issue, I couldn't figure out why excanvas doesn't render image properly (after rotation)/.

IE9 works as expected, but I understand that IE7/8 support for this could be very crucial.

I'll look into it once again, asap.

@lukluk
Copy link

lukluk commented Nov 2, 2012

awsome

@fadamakis
Copy link

Is anyone working on this?
I think this is crucial but I'm kinda lost trying to find the problem.

@kangax
Copy link
Member

kangax commented Nov 8, 2012

IIRC, I ran into excanvas limitation last time I looked at it. Does
excanvas support drawing image with custom transformation?

On Thu, Nov 8, 2012 at 5:59 PM, Fotis Adamakis notifications@github.comwrote:

Is anyone working on this?
I think this is crucial but I'm kinda lost trying to find the problem.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-10195676.

@lukluk
Copy link

lukluk commented Nov 9, 2012

why we not redirect user to install google chrome frame for IE, iam so stressed , IE very sensitive like a girl haha

@raichu
Copy link

raichu commented Mar 29, 2013

Any developments on this issue?
I checked excanvas, transformations were apparently introduced in r46.

@raichu
Copy link

raichu commented Mar 29, 2013

Just tried it using IE7 and IE8 modes of IE9, transformations worked okay.
Can someone confirm these results with real IE7 and IE8?

@kangax
Copy link
Member

kangax commented Mar 29, 2013

As far as I know, the bug is still in excanvas (you can see a link to it and more in https://github.com/kangax/fabric.js/wiki/Fabric-limitations-in-oldIE)

There's an unofficial patch that supposedly fixes it but I haven't had a chance to try it yet. If anyone can try it and confirm, that would be great!

@raichu
Copy link

raichu commented Mar 31, 2013

Tried the tests in http://dev.sencha.com/playpen/tm/excanvas-patch/, they pass fine on real IE6 (XP).
Unfortunately, the patch is't applied to the upsteam, so maybe fabric.js can maintain it's own version of excanvas.js with the patch applued?

@kangax
Copy link
Member

kangax commented Mar 31, 2013

@raichu Thanks for looking into it. I applied the patch to excanvas.js that we had under /lib. Surprisingly, it applied clean. I then checked in IE8 mode under IE10 (in virtual machine) and while I see that image sizes now seem to be respected (yay!), the position still seems to be defunct. I can move bounding box, but the actual image is always rendered in top/left corner. You should be able to see this on fabricjs.com, which I updated with newly-patched excanvas.

@raichu
Copy link

raichu commented Mar 31, 2013

Wow, I never thought it would be default on fabricjs.com so quickly --thanks!! I just fired up the patterns and controls demos (real IE6, under XP), and everything works just fine. I can move, rotate and scale the image without problems (except I'm getting the wrong mouse cursor when scaling while keeping the aspect-ratio at the corners, but it probably doesn't have anything to do with the canvas). Maybe the IE8 mode isn't really realiable?

@kangax
Copy link
Member

kangax commented Mar 31, 2013

Yeah, IE8 mode could definitely be the problem. I'm glad to hear it's
working for you on IE6. Do you have a way of checking on real 7 and 8?

On Sun, Mar 31, 2013 at 7:01 PM, raichu notifications@github.com wrote:

Wow, I never thought it would be default on fabricjs.com so quickly
--thanks!! I just fired up the patterns and controls demos (real IE6, under
XP), and everything works just fine. I can move, rotate and scale the image
without problems (except I'm getting the wrong mouse cursor when scaling
while keeping the aspect-ratio at the corners, but it probably doesn't have
anything to do with the canvas). Maybe the IE8 mode isn't really realiable?


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-15694215
.

@raichu
Copy link

raichu commented Apr 1, 2013

Works even better on IE7 (XP): the mouse cursor is the correct one. I'll try to test it on IE8 as well, but I think it'll all be okay.

@kangax
Copy link
Member

kangax commented Apr 1, 2013

Cool. I'm closing this then. If anyone else can confirm, that would be great.

@kangax kangax closed this as completed Apr 1, 2013
@kangax
Copy link
Member

kangax commented Apr 1, 2013

Now, if we could make other stuff work :)

@Kienz
Copy link
Collaborator

Kienz commented Apr 2, 2013

I tested it on real IE8 (Win 7) and it worked (rotate, move, scale).

@kangax
Copy link
Member

kangax commented Apr 2, 2013

That's great, thanks for confirming @Kienz!

kangax pushed a commit that referenced this issue Jul 10, 2014
asturur added a commit that referenced this issue May 5, 2015
WietseWind added a commit to WietseWind/fabric.js that referenced this issue Sep 19, 2017
asturur pushed a commit that referenced this issue Sep 29, 2017
* Fix IE rendering of SVG as overlay image

* Fix IE rendering of SVG as overlay image #2 - Fix coding syntax (CI)

* Fix IE rendering of SVG as overlay image #3 - Fix coding syntax (CI)

* Fix IE rendering of SVG as overlay image #4 - Moved to method 'loadImageInDom'

* Fix IE rendering of SVG as overlay image #5 - Moved some stuff around

* Fix IE rendering of SVG as overlay image #6 - Fixed the setTimeout (removed)

* Update misc.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants