Why is the strokeUniform variable remarked in the toObject function?

[joyk1130]

I set the strokeUniform variable to true to fix the stroke size when increasing or decreasing the object scale.
When I use the clone function, the stroke result is different.
The strokeUniform value is not copied when creating a clone.

If you look at the fabric.js file, the strokeUniform value is remarked in the toObject function, but I wonder why!

This is my example :
http://jsfiddle.net/Nicky_Jo/zb6Lrvod/

[asturur]

Unclear how to use the fiddle.

What do you mean by remarked?

[joyk1130]

I mean this line.
I use fabric 4.1.0 version.

This is my fiddle how to use.

1. Click a orange color rectangle.
2. scaleup select object.
3. ctrl+c -> orange rectangle
4. ctrl+v

Result:

[asturur]

that line shouldn't be commented. Is wrong. Should be fixed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jaltekruse]

@asturur I'm interested in getting this fixed. I see the TODO comment was added/removed in these PRs, but I'm not sure that it addressed any/all possible problems that were the reason it was commented originally.

added - https://github.com/fabricjs/fabric.js/pull/6118/files
TODO removed - commented line remains - https://github.com/fabricjs/fabric.js/pull/6280/files

Could you point me at some areas to test/fix to enable this to be safely uncommented? Happy to contribute fixes, just a pointer in the right direction would be helpful.

[asturur]

I think the issue was just me have a terrible test suite and need to update all the things manually.
Let's do that and let's get this thing solved.

[jaltekruse]

Got it, there are probably just tests that have hard-coded exports saved, and those need to be updated? Sounds like a good newbie task, I'll uncomment and try to get the tests all passing.

[asturur]

oh do not worry! i just started it. I needed to fix it too for work, but i used a workaround and then i forgot.

…

On Thu, 31 Dec 2020 at 15:31, Jason Altekruse ***@***.***> wrote: Got it, there are probably just tests that have hard-coded exports saved, and those need to be updated? Sounds like a good newbie task, I'll uncomment and try to get the tests all passing. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#6641 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJDQQGVZQVKW3X3WN5UAQLSXSDKHANCNFSM4SKLT52A> .