Some fixes to textbox #2347
Merged
Some fixes to textbox #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jafferhaider @inssein have a look please |
|
Looks good to me, thanks for catching and fixing that @asturur. I had to do the same for some of the functions in the mixins (https://github.com/kangax/fabric.js/blob/master/src/mixins/textbox_behavior.mixin.js#L68). |
| }, | ||
|
|
||
| /** | ||
| * Calculate a styleMap that lets us know where styles as, as _textLines is separated by \n and wraps, | ||
| * but the style object line indices is by \n. |
There was a problem hiding this comment.
@asturur could you please rephrase this? it's difficult to understand it as it is
There was a problem hiding this comment.
Generate an object that translates the style object so that it is broken up by visual lines (new lines and automatic wrapping). The original text styles object is broken up by actual lines (new lines only), which is only sufficient for Text / IText.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires to update stylemap from splitTextLines to work with latestchanges of Itext Style.
Fill the cache array of this.__lineWidths that some functions expect to have.
closes #2339
canvas:
svg:
