fixing callSuper #3844
Merged
fixing callSuper #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what the hell, once o renamed |
|
hmmmm yea I can't see any reason that this would happen. I actually tried making this change in editor fabric just to make sure I wasn't crazy. That leaves either the build process for this project or some edge case failure as culprits. |
|
canvas prebuilt for node linux x64 has been updated and locked down something. |
asturur
pushed a commit
that referenced
this pull request
Apr 22, 2017
* fixing callSuper * fixing lint * fixed unexpected alias for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present callSuper can go into an infinite loop if it is called above the bottom level in the prototype chain, this fixes that.
This fix allows fixing the IText class to run
callSuper('onDeselect').Also placing an empty function on the
fabric.Objectclass in case there is noonDeselectdefined on the parent.thank you for your help @asturur