fix v4: 'scaling' event triggered before object position is adjusted #6650
Conversation
src/controls.actions.js
Outdated
| * @param {Function} actionHandler the function to wrap | ||
| * @return {Function} a function with an action handler signature | ||
| */ | ||
| function wrapWithFixedAnchor(actionHandler) { | ||
| function wrapWithFixedAnchor(eventName, actionHandler) { |
There was a problem hiding this comment.
we can't change wrapWithFixedAnchor argument signature, or we would break the compatibility of fabric v4.
There was a problem hiding this comment.
we need an event wrapper, or something like that. I ll get some fixes done and then i ll try to help.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This still a valid issue |
|
I do not have the pipeline to check it, or the time to fix the test errors, but we definitely need this as a reminder to fix it. |
|
@asturur I updated the PR to not change the argument signature |
|
hi @SLKnutson i know a lot of time passed, but now the pipeline is working again. |
|
@asturur |
merge latest in
|
hi @SLKnutson i ll review asap |
|
seems great tho |
|
+1 exactly what I need. Bleeded a day on this. |
|
Thanks for this! Turns out this was the cause of a bug in my application that started a few versions ago. |
Hopefully this is satisfactory. It worked in my project.
#6649
Thanks!