Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animation): delay #7805

Merged
merged 1 commit into from Mar 25, 2022
Merged

feat(animation): delay #7805

merged 1 commit into from Mar 25, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Mar 14, 2022

closes #1719

This Pr introduces a new delay property for the fabric.util.animate function options.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.17 |    76.59 |   86.32 |   82.89 |                                               
 fabric.js |   83.17 |    76.59 |   86.32 |   82.89 | ...,29878,30003,30083-30148,30271,30370,30587 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Mar 25, 2022

#6390

What do you think of this PR?
I would like to expand it further, but i wonder how to reconcile it with normal animations.

@asturur asturur merged commit 8e2ee5b into master Mar 25, 2022
@ShaMan123 ShaMan123 deleted the anim-delay branch March 26, 2022 00:07
@ShaMan123
Copy link
Contributor Author

#6390

What do you think of this PR? I would like to expand it further, but i wonder how to reconcile it with normal animations.

I looked it a while back. Looks interesting. Should be straight forward to wrap the new concept with in a way that supports normal animations

@brandonSeattle
Copy link

When this delay updates will be available?

@el
Copy link

el commented Jul 21, 2022

Bump. Do you have an ETA for this in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animation delay
4 participants