test(freedrawing): test enhancement

[ShaMan123]

This PR is a byproduct of the next PR that will add erasing visual tests.
I added logic to freedrawing tests to prepare for testing erasing and decided (with your voice guiding me :)) to split up the PR into dedicated changes.
This PR adds another layer of tests to free drawing by testing visuals before and after mouseup and comparing between them.
I think it's relevant and to the point.
It is proven by the tests failing (freedrawing4 - Simple free drawing, with opacity) - you might want to output the mesh result to a different file to compare changes. It might be desirable in general so tell me if to commit a different golden name for the mesh test. Shadow + opacity cause this it seems

[ShaMan123]

What about the failing test?

[asturur]

oh i assumed the failing test was firefox as usual

[asturur]

Is the broken test a new test?
i see it has opacity and shadow, was the golden built with node?

[asturur]

The website visual test got broken, probably the qunit update.
I need to fix that so i can see the difference in chrome/firefox

[ShaMan123]

i see it has opacity and shadow, was the golden built with node?

The test was built in node. It is a new test. It's the upper canvas test.

[asturur]

We can fix the the display in browser, take the golden from there, and disable the node test once we understand how much the difference is. With shadow and opacity is mostly normal

[ShaMan123]

I have just updated ruby so I can't serve the website as well.
Makes sense to disable the test on node as it is interactive visuals only.

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.04 |    75.94 |   85.69 |   82.77 |                                               
 fabric.js |   83.04 |    75.94 |   85.69 |   82.77 | ...,30850,30924,30935-31000,31123,31222,31458 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.09 |    75.98 |   85.69 |   82.82 |                                               
 fabric.js |   83.09 |    75.98 |   85.69 |   82.82 | ...,30850,30924,30935-31000,31123,31222,31458 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.1 |    76.01 |   85.69 |   82.83 |                                               
 fabric.js |    83.1 |    76.01 |   85.69 |   82.83 | ...,30850,30924,30935-31000,31123,31222,31458 
-----------|---------|----------|---------|---------|-----------------------------------------------

[ShaMan123]

I have managed to serve the website

expected is golden generated in node
actual is generated in browser (chrome)

[ShaMan123]

If I understand correctly node canvas doesn't apply opacity to the shadow...
What is the expected behavior?

[asturur]

we can take the browser one that is most common case ( especially for free drawing ) and we can disable the test when we detect node with fabric.isLikelyNode and move forward.
Did you manage to fix the qunit display in the website?
I remember i worked on it really recently and i fixed it.

[asturur]

i fixed it here, then:

i broke it there and i didn't verify it.

I saw we updated qunit in fabric and i thought it was a good idea to have the same version

[asturur]

When hiding passed tests is still broken, anyway, there are 22 failing tests in 5.2.0 mostly on svg import, i wonder what happened

[ShaMan123]

I don't see any of it...
Did you run the start cmd from fabric.js dir?

[ShaMan123]

i fixed it here, then:

i broke it there and i didn't verify it.

I saw we updated qunit in fabric and i thought it was a good idea to have the same version

Where is this? In the website? I have the website up and running locally

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.05 |    75.98 |   85.69 |   82.78 |                                               
 fabric.js |   83.05 |    75.98 |   85.69 |   82.78 | ...,30850,30924,30935-31000,31123,31222,31458 
-----------|---------|----------|---------|---------|-----------------------------------------------

[ShaMan123]

All set

[ShaMan123]

I forget about the json...
I guess it will wait for es6