Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Textbox): flipped changeWidth control behavior #7980

Merged
merged 8 commits into from Jun 10, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented May 30, 2022

This PR fixes the change width control.
It used to change width as if it were flipped.
Now it doesn't.
Should I adapt the logic to enable more corners?

Before

Fabric.React.App.Sandbox.-.Google.Chrome.2022-05-31.00-23-33.mp4

After

Fabric.React.App.Sandbox.-.Google.Chrome.2022-05-31.00-24-40.mp4

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.05 |    75.97 |   85.69 |   82.77 |                                               
 fabric.js |   83.05 |    75.97 |   85.69 |   82.77 | ...,30855,30929,30940-31005,31128,31227,31463 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.06 |       76 |   85.69 |   82.78 |                                               
 fabric.js |   83.06 |       76 |   85.69 |   82.78 | ...,30857,30931,30942-31007,31130,31229,31465 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 changed the title fix(Textbox): flipped change width control behavior fix(Textbox): flipped changeWidth control behavior Jun 10, 2022
@ShaMan123 ShaMan123 requested a review from asturur June 10, 2022 13:14
@ShaMan123 ShaMan123 merged commit f722778 into master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants