New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EraserBrush): visual trace while erasing #7991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a **hack** that reduces the path width while clipping the main context, resulting in a better visual overlap of both contexts The issue's cause is unknown at time of writing - I don't understand why this is happening. closes #7984
Code Coverage Summary
|
This reverts commit 682e093.
Code Coverage Summary
|
Code Coverage Summary
|
Code Coverage Summary
|
ShaMan123
commented
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready.
Anyways it is not breaking because I've exposed the prop erasingWidthAliasing
that can be set to 0 to revert to previous behavior.
asturur
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hack that reduces the path width while clipping the main context, resulting in a better visual overlap of both contexts
The issue's cause is unknown at time of writing - I don't understand why this is happening.
Added another minor change of the masking logic. Instead of source-over I reversed the order to use destination-in. Shouldn't affect anything and is simpler to grasp.
closes #7984