chore(TS): Move more utils to TS #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary |
asturur
commented
Aug 21, 2022
Comment on lines
-549
to
-571
| parsePreserveAspectRatioAttribute: function(attribute) { | ||
| var meetOrSlice = 'meet', alignX = 'Mid', alignY = 'Mid', | ||
| aspectRatioAttrs = attribute.split(' '), align; | ||
|
|
||
| if (aspectRatioAttrs && aspectRatioAttrs.length) { | ||
| meetOrSlice = aspectRatioAttrs.pop(); | ||
| if (meetOrSlice !== 'meet' && meetOrSlice !== 'slice') { | ||
| align = meetOrSlice; | ||
| meetOrSlice = 'meet'; | ||
| } | ||
| else if (aspectRatioAttrs.length) { | ||
| align = aspectRatioAttrs.pop(); | ||
| } | ||
| } | ||
| //divide align in alignX and alignY | ||
| alignX = align !== 'none' ? align.slice(1, 4) : 'none'; | ||
| alignY = align !== 'none' ? align.slice(5, 8) : 'none'; | ||
| return { | ||
| meetOrSlice: meetOrSlice, | ||
| alignX: alignX, | ||
| alignY: alignY | ||
| }; | ||
| }, |
There was a problem hiding this comment.
this has been rewrote to be TS friendly and readable.
I had to re-read the spec because i couldn't read anymore what this code was doing.
ShaMan123
reviewed
Aug 21, 2022
| pc = 'pc', | ||
| em = 'em', | ||
| } | ||
|
|
||
| export type TMat2D = [number, number, number, number, number, number]; |
There was a problem hiding this comment.
export type TMat2DBasic = [number,number,number,number];
export type TMat2DAffine = [number,number,number,number,number,number];
export type TMat2D<T> = TMat2DAffine |TMat2DBasic;
export type...
ShaMan123
reviewed
Aug 21, 2022
| @@ -1,7 +1,6 @@ | |||
| //@ts-nocheck | |||
|
|
|||
| import { fabric } from '../../HEADER'; | |||
| import { toArray } from '../util'; | |||
There was a problem hiding this comment.
why not import directly from the file lang_array and not from the index?
That will solve the circular dep
There was a problem hiding this comment.
Is what i was doing i removed for now all imports from the main index in util, and where possible i m linking to direct files.
Is probably better to leave the util/index.ts just to create the external facing export for who will use fabric.util
ShaMan123
reviewed
Aug 21, 2022
Code Coverage Summary |
Yes, and there are also some duplicated functions here and there. |
|
rolling back to before moving svgParsing. can't unbreak what i broke |
asturur
force-pushed
the
more-more-more-utils
branch
from
cc18599
to
bfee157
Compare
Code Coverage Summary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving more utils