chore(TS) convert more utils #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaMan123
reviewed
Aug 25, 2022
| @@ -33,7 +33,7 @@ type TComposeMatrixArgs = TTranslateMatrixArgs & TRotateMatrixArgs & TScaleMatri | |||
| * @param {Boolean} [ignoreOffset] Indicates that the offset should not be applied | |||
| * @return {Point} The transformed point | |||
| */ | |||
| export const transformPoint = (p: Point | IPoint, t: TMat2D, ignoreOffset: boolean): Point => new Point(p).transform(t, ignoreOffset); | |||
| export const transformPoint = (p: Point | IPoint, t: TMat2D, ignoreOffset?: boolean): Point => new Point(p).transform(t, ignoreOffset); | |||
There was a problem hiding this comment.
aren't we moving this to point? same as rotatePoint?
There was a problem hiding this comment.
is already on point, this is the old util that uses the point method
| import { invertTransform, multiplyTransformMatrices, qrDecompose } from "./matrix"; | ||
| import type { TComposeMatrixArgs } from './matrix'; | ||
|
|
||
| type FabricObject = any; |
There was a problem hiding this comment.
Maybe we should put this in typedefs so it will be easy to replace...
I didn't put too much thought into it when I did it
There was a problem hiding this comment.
me neither. is just to remember we need a generic type that accept any fabricObject interface.
Code Coverage Summary |
frankrousseau
pushed a commit
to cgwire/fabric.js
that referenced
this pull request
Jan 6, 2023
Co-authored-by: ShaMan123 <shacharnen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain conversion of add/remove transforms to object and make bounding box from points