Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(): fabric.console #8184

Merged
merged 5 commits into from
Aug 26, 2022
Merged

dep(): fabric.console #8184

merged 5 commits into from
Aug 26, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Aug 25, 2022

remove dead code fabric.console

#8183 removes the last remaining usage

@ShaMan123 ShaMan123 requested a review from asturur August 25, 2022 12:21
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.58 |   84.45 |   80.69 |                                               
 fabric.js |    82.1 |    74.58 |   84.45 |   80.69 | ...,27440,27498,27508-27552,27660,27747,27951 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Aug 26, 2022

this is fine,
if we ever need special logging we can add it.

@ShaMan123
Copy link
Contributor Author

bye bye then

@ShaMan123 ShaMan123 merged commit c4a2946 into master Aug 26, 2022
@ShaMan123 ShaMan123 deleted the dep-console branch September 11, 2022 23:36
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants