Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TS): move control files under controls folder #8185

Merged
merged 12 commits into from Aug 26, 2022
Merged

chore(TS): move control files under controls folder #8185

merged 12 commits into from Aug 26, 2022

Conversation

ShaMan123
Copy link
Contributor

A first patch moving control files under a designated folder and fixing imports
after this is merged a full migration will be done in a separate PR to keep history

@ShaMan123 ShaMan123 changed the title chore(TS): move controls under controls folder chore(TS): move control files under controls folder Aug 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.09 |    74.55 |   84.46 |   80.69 |                                               
 fabric.js |   82.09 |    74.55 |   84.46 |   80.69 | ...,27768-27789,27807,27810-27811,27847-27848 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.57 |   84.46 |    80.7 |                                               
 fabric.js |    82.1 |    74.57 |   84.46 |    80.7 | ...,27769-27790,27808,27811-27812,27848-27849 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.09 |    74.54 |   84.46 |   80.69 |                                               
 fabric.js |   82.09 |    74.54 |   84.46 |   80.69 | ...,27769-27790,27808,27811-27812,27848-27849 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.57 |   84.46 |    80.7 |                                               
 fabric.js |    82.1 |    74.57 |   84.46 |    80.7 | ...,27769-27790,27808,27811-27812,27848-27849 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 requested a review from asturur August 26, 2022 08:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.17 |    74.65 |   84.35 |   80.79 |                                               
 fabric.js |   82.17 |    74.65 |   84.35 |   80.79 | ...-27676,27792-27793,27814-27855,27870-28029 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022 •
edited

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.13 |    74.65 |   84.35 |   80.75 |                                               
 fabric.js |   82.13 |    74.65 |   84.35 |   80.75 | ...-27676,27792-27793,27814-27855,27870-28029 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur
asturur reviewed Aug 26, 2022
View reviewed changes
src/mixins/canvas_events.mixin.ts
_fire: fabric.controlsUtils.fireEvent,
_fire: function (eventName, options) {
return fireEvent(eventName, options);
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does have it to be a delegate? can't be continue to be an alias?

@ShaMan123 ShaMan123 merged commit f9761dd into master Aug 26, 2022
@ShaMan123 ShaMan123 deleted the ts-controls branch September 11, 2022 23:36
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
@ShaMan123 @frankrousseau
chore(TS): move control files under controls folder (fabricjs#8185)
f150b75 
* move to `controls` folder

* es6 `controls.render`

* Update testem.config.js

* extract `fireEvent`

* fix(): naming error

* Update typedefs.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShaMan123 @asturur