fix(ci): report build script failure + revert node test runner to QUnit #8188

ShaMan123 · 2022-08-25T17:46:46Z

same as #8187 for build script (propagate exit code to main process for ci)
refactor the test function a bit
revert to running node tests with QUnit instead of testem, dedicated to @asturur

closes #8186 tests were failing because the process didn't receive the exit code

github-actions · 2022-08-25T17:52:22Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.56 |   84.46 |    80.7 |                                               
 fabric.js |    82.1 |    74.56 |   84.46 |    80.7 | ...,27455,27513,27523-27567,27675,27762,27966 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-25T18:09:02Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.56 |   84.46 |    80.7 |                                               
 fabric.js |    82.1 |    74.56 |   84.46 |    80.7 | ...,27455,27513,27523-27567,27675,27762,27966 
-----------|---------|----------|---------|---------|-----------------------------------------------

This reverts commit d9d1f49.

github-actions · 2022-08-25T18:22:11Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.56 |   84.46 |    80.7 |                                               
 fabric.js |    82.1 |    74.56 |   84.46 |    80.7 | ...,27455,27513,27523-27567,27675,27762,27966 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-25T19:18:13Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.56 |   84.46 |    80.7 |                                               
 fabric.js |    82.1 |    74.56 |   84.46 |    80.7 | ...,27455,27513,27523-27567,27675,27762,27966 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-25T19:23:49Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.15 |     74.6 |   84.46 |   80.76 |                                               
 fabric.js |   82.15 |     74.6 |   84.46 |   80.76 | ...,27455,27513,27523-27567,27675,27762,27966 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-25T19:24:25Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.15 |     74.6 |   84.46 |   80.76 |                                               
 fabric.js |   82.15 |     74.6 |   84.46 |   80.76 | ...,27455,27513,27523-27567,27675,27762,27966 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-26T08:54:38Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.13 |    74.64 |   84.35 |   80.75 |                                               
 fabric.js |   82.13 |    74.64 |   84.35 |   80.75 | ...-27675,27791-27792,27813-27854,27869-28028 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-27T11:15:23Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.69 |   84.44 |   80.67 |                                               
 fabric.js |   82.05 |    74.69 |   84.44 |   80.67 | ...-27584,27700-27701,27722-27763,27778-27937 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

READY!

github-actions · 2022-08-27T11:24:31Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.69 |   84.44 |   80.67 |                                               
 fabric.js |   82.05 |    74.69 |   84.44 |   80.67 | ...-27584,27700-27701,27722-27763,27778-27937 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

removed your cmds

let's get rid of build.js if we are at it

github-actions · 2022-08-27T11:53:30Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.69 |   84.44 |   80.67 |                                               
 fabric.js |   82.05 |    74.69 |   84.44 |   80.67 | ...-27584,27700-27701,27722-27763,27778-27937 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur

@asturur this is what I meant in the comments of #8206

github-actions · 2022-08-29T06:50:00Z

Coverage after merging testem-fix-failing into master will be

80.74%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
dist
fabric.js	78.88%	74.72%	84.36%	80.74%	10044, 10056, 10070, 10099, 10116–10117, 10120, 10129–10130, 10130, 10130–10131, 10133–10135, 10142, 10142, 10142–10144, 10146–10147, 10154–10156, 10183–10185, 10187–10188, 10191–10192, 10263, 10282–10284, 10286–10287, 10349, 1036, 10403, 10418, 10474, 10510–10511, 10517, 10521–10522, 10537, 10571, 10602–10603, 10627, 10635, 10722, 10754–10755, 10830–10831, 10834, 10839, 10861, 10861, 10861, 10861, 10861, 10861, 10861–10862, 10864–10865, 10865, 10865–10866, 10871, 10873, 10879, 10879, 10879, 10879, 10879–10880, 10882–10886, 10886, 10886–10888, 10890–10891, 10900, 10911, 10922, 10933, 10943–10946, 10954–10955, 10955, 10955–10956, 10958–10959, 10966, 10970, 1111, 1113–1114, 1116–1117, 1124, 1128, 1136, 11567, 11572, 116, 11614–11616, 11616, 11616, 11616, 11616, 11616–11617, 11637, 11642–11643, 11691–11692, 11706, 11706, 1172, 1174, 1174, 1174, 1174, 1174, 11749, 11749, 11749, 1175, 11751, 11899, 119, 11900, 11911, 120, 12068–12069, 12076, 121, 12119, 12126, 12126, 12135–12136, 12147, 12187, 12195, 12214–12216, 12243–12244, 12247, 12247, 12264–12266, 12369, 12454–12455, 12457–12458, 12465, 12489, 12554–12555, 12559, 12639, 12648, 12653, 12690, 12791, 12791, 12791, 128, 12815–12816, 129, 129, 129, 129, 129, 129, 129, 12924, 12927, 12989, 12995, 130, 13002, 13009, 13015, 13021, 13028, 13035, 13041–13042, 13042, 13042, 13057–13058, 13066, 13075, 13075, 131, 13100–13103, 13141, 13184–13185, 13225–13226, 133, 13359–13360, 1341, 1341, 1343, 13505, 13597, 13660, 13663, 13716–13717, 13717, 13717, 13720, 13735, 13749, 13761–13762, 13764, 13776–13777, 13779, 13794, 13809–13810, 13812–13813, 13815–13816, 13826, 13856, 13856, 13856, 13856, 13856, 13856, 13856, 13856, 13881, 13883, 13883–13885, 1393, 13938–13940, 13963, 13971, 13977–13978, 14019, 14082–14083, 14117, 14138–14139, 14198, 14198, 14198, 14198, 14198, 14203–14211, 14253, 14379–14380, 14416, 14425, 14446, 14446, 14446–14447, 14447, 14447, 14447, 14447–14448, 14454–14456, 14459–14460, 14473, 14473, 14473–14474, 14474, 14474, 14474, 14474–14475, 14481–14483, 14486–14487, 14500–14501, 14575, 14624, 14628, 14753, 14783–14784, 14784, 14784–14785, 14785, 14785–14786, 14788, 14788, 14788–14789, 14792, 14799, 14884, 14997, 15046, 15116, 15120, 1513, 15190, 15247–15248, 15262, 15312–15313, 15315–15316, 154, 15408, 15468, 15471, 15546, 15549, 15564–15565, 15574, 15616, 15620, 15645–15646, 15680, 15684, 1574, 158, 158, 158, 158, 158–159, 15950, 15954, 16118, 16121, 16128–16129, 16129, 16129–16131, 16133, 16133, 16133–16135, 16135, 16135–16137, 162, 162, 16227, 16232–16234, 16262–16263, 163, 163, 163, 163, 163, 16330, 16333, 16333, 16333–16334, 16336–16337, 16337, 16337–16338, 16338, 16338, 16340–16341, 16343, 16346, 16373, 16373–16375, 164, 16424, 16424, 16459, 16494, 16494, 16494, 16497–16498, 16500, 16500, 16504, 16507, 16510, 16512–16513, 16522, 16527, 16527–16529, 16529, 16540–16541, 16550, 16550, 16550, 16550, 16550–16551, 16551, 16551–16553, 16553–16554, 16554, 16571–16572, 16572, 16572, 16594–16595, 16595, 16595, 16595, 16595, 16595, 16607, 16607, 16610–16614, 16614, 16653, 16692, 167, 16724, 16727–16730, 16740, 16753, 16768, 16785, 16794, 16798, 1685, 16850, 16852–16854, 1686, 16868, 16870–16871, 16887, 169, 16939, 16962, 170, 17095, 17157–17159, 17159–17160, 17160, 17188, 17233–17236, 17243, 17245–17246, 17261–17263, 17273, 17273, 17273, 17336, 17348, 17348, 17395–17396, 17414–17415, 17436, 17478, 17478–17479, 17496–17499, 17499, 17499–17500, 17502, 17502, 17502–17503, 17505–17506, 17506, 17506–17507, 17509, 17509, 17509–17510, 17512–17513, 17517–17518, 17565, 17609, 17678, 17683, 17706–17710, 17710, 17710–17711, 17713, 17721, 17724, 17724, 17724–17726, 17726, 17726–17728, 17728, 17728–17732, 17736–17737, 17744, 17744, 17744, 17744, 17744–17745, 17747–17748, 17764–17765, 17767–17768, 17775–17778, 17781, 17784, 17786–17787, 17787, 17787, 17787, 17787, 17787, 17787–17788, 17790, 17792–17793, 17793, 17793–17796, 17798, 17805–17813, 17813, 17813–17815, 17818, 17826–17829, 17835–17836, 17836, 17836–17837, 17839, 17839, 17839–17840, 17842, 17844–17845, 17860, 17862, 17862, 17862–17863, 17865–17866, 17866–17867, 17867, 17873, 17873, 17875, 17875–17876, 17876, 17885–17887, 17887, 17887–17895, 17901, 17901, 17901–17903, 17905,

https://api.qunitjs.com/extension/QUnit.onUncaughtException/

This reverts commit 89ad18b.

https://github.com/fabricjs/fabric.js/runs/8084222669?check_suite_focus=true

This reverts commit a93e652.

ShaMan123 added 6 commits August 25, 2022 17:05

fix(): propagate failed exit code to the process

fba6378

closes #8186 tests were failing because the process didn't receive the exit code

Update index.js

8572cae

Update index.js

1975366

build

e4c899a

refactor

fd2ced1

Update index.js

7e07ed7

ShaMan123 requested a review from asturur August 25, 2022 17:47

ShaMan123 added the CI/CD label Aug 25, 2022

Merge branch 'master' into testem-fix-failing

00720f4

Update index.js

e0ab5eb

Revert "commit build error"

dcba816

This reverts commit d9d1f49.

better comment

78edbc4

ShaMan123 added 2 commits August 25, 2022 22:21

catch the eye

c774732

Update index.js

1eef7e2

Merge branch 'master' into testem-fix-failing

01de59f

ShaMan123 added 2 commits August 27, 2022 14:09

revert node testing to qunit cmd

174fdbe

Merge branch 'master' into testem-fix-failing

a7cef72

ShaMan123 changed the title ~~fix(ci): report build script failure~~ fix(ci): report build script failure + revert node test runner to QUnit Aug 27, 2022

Update index.js

7ff48cd

ShaMan123 commented Aug 27, 2022

View reviewed changes

remove cmds

80a778a

ShaMan123 commented Aug 27, 2022

View reviewed changes

reintroduce node golden generation

ee3388c

@asturur this is what I meant in the comments of #8206

ShaMan123 added 7 commits August 30, 2022 06:19

default verbose true

b852b88

Merge branch 'master' into testem-fix-failing

508f338

fix(test): catch unhandled rejection

ba54236

https://api.qunitjs.com/extension/QUnit.onUncaughtException/

Update node_test_setup.js

89ad18b

Revert "Update node_test_setup.js"

16fc147

This reverts commit 89ad18b.

ci error

a93e652

https://github.com/fabricjs/fabric.js/runs/8084222669?check_suite_focus=true

Revert "ci error"

a1bd2dd

This reverts commit a93e652.

asturur previously approved these changes Aug 30, 2022

View reviewed changes

asturur dismissed their stale review via 3580acd August 30, 2022 05:56

those are useful

3580acd

asturur approved these changes Aug 30, 2022

View reviewed changes

asturur merged commit 195eeff into master Aug 30, 2022

asturur deleted the testem-fix-failing branch September 11, 2022 23:03

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023

fix(ci): report build script failure + fix missing logs (fabricjs#8188)

bd0e238

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): report build script failure + revert node test runner to QUnit #8188

fix(ci): report build script failure + revert node test runner to QUnit #8188

ShaMan123 commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

ShaMan123 left a comment

github-actions bot commented Aug 27, 2022 •

edited

ShaMan123 left a comment

github-actions bot commented Aug 27, 2022 •

edited

github-actions bot commented Aug 29, 2022 •

edited

fix(ci): report build script failure + revert node test runner to QUnit #8188

fix(ci): report build script failure + revert node test runner to QUnit #8188

Conversation

ShaMan123 commented Aug 25, 2022 • edited

github-actions bot commented Aug 25, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 25, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 25, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 25, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 25, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 25, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 26, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 27, 2022 • edited

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 27, 2022 • edited

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 27, 2022 • edited

Code Coverage Summary

github-actions bot commented Aug 29, 2022 • edited

ShaMan123 commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 25, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

github-actions bot commented Aug 29, 2022 •

edited