chore(TS): Image #8443

ShaMan123 · 2022-11-17T15:08:12Z

Motivation

Description

Changes

Gist

In Action

github-actions · 2022-11-17T15:09:45Z

Build Stats

file / KB (diff)	bundled	minified
fabric	1049.240 (-7.710)	311.456 (-0.785)

src/shapes/image.class.ts

ShaMan123 · 2022-11-17T15:13:39Z

src/shapes/image.class.ts

+   * @param filtered
+   * @deprecated
+   */
+  getSvgSrc(filtered?: boolean) {


can be removed

ShaMan123 · 2022-11-17T15:14:03Z

src/shapes/image.class.ts

+   * @param {Array} filters to be applied
+   * @param {Boolean} forResizing specify if the filter operation is a resize operation
+   */
+  applyFilters(filters = this.filters || []) {


failing tests for some reason

ShaMan123 · 2022-11-17T15:16:09Z

src/shapes/image.class.ts

-       * @private
-       * @param {Object} [options] Options object
-       */
-      _initConfig: function (options) {


ShaMan123

almost done

remove `_initElement`

asturur · 2022-11-19T22:09:07Z

the merge conflicts aren't great here. Must be my filter change.
Can you prioritize fixing this merge conflict before doing other fabricJS work?

ShaMan123 · 2022-11-19T22:35:52Z

Tomorrow I will finish this up

ShaMan123

triaging

src/shapes/image.class.ts

github-actions · 2022-11-21T11:01:03Z

Coverage after merging ts-image into master will be

82.32%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
HEADER.js	54%	48.15%	0%	63.64%	12, 14, 14, 14, 14, 14, 16–17, 21, 21–22, 22, 22, 24, 24, 26, 28, 30–31, 77, 77, 77
src
cache.ts	97.06%	90%	100%	100%	57
canvas.class.ts	93.36%	90.22%	94.12%	95.54%	1045, 1045–1046, 1049, 1069, 1069, 1104, 1137–1138, 1166–1167, 1200, 1208, 1318–1319, 1321–1322, 1342–1343, 1501, 1506, 1516, 1520, 472–473, 478, 487, 636–638, 683–684, 733–734, 737, 739, 782–784, 826, 831–832, 860–861
config.ts	77.27%	66.67%	66.67%	84.62%	130, 138–140, 151–153
constants.ts	100%	100%	100%	100%
intersection.class.ts	100%	100%	100%	100%
pattern.class.ts	92.19%	85.71%	100%	96.30%	110, 116, 127, 136, 88
point.class.ts	100%	100%	100%	100%
shadow.class.ts	98.51%	96%	100%	100%	156
static_canvas.class.ts	90.15%	83.90%	96.70%	92.73%	1112–1113, 1113, 1113–1114, 1248, 1314–1315, 1318, 1367–1368, 1461, 1476, 1480, 1506–1507, 1536–1537, 1570–1571, 1612–1613, 1616, 1618, 1618, 1618, 1618, 1622, 1622, 1622–1624, 1646–1647, 1688–1689, 1692, 1694, 1694, 1694, 1694, 1698, 1698, 1698–1700, 1771, 1771–1772, 1830, 1832, 1832, 1832, 1832, 1832–1833, 1836–1837, 1837, 1837–1838, 1841, 1841, 1841, 1843, 1846, 1852, 1854–1855, 1855, 1855, 1858–1859, 1859, 1859, 1862, 319–320, 322–323, 325–326, 339–340, 342–343, 57, 658–661, 861
src/brushes
base_brush.class.ts	100%	100%	100%	100%
circle_brush.class.ts	2.99%	0%	0%	3.92%	102–103, 105, 107–109, 118, 118, 118, 120, 122, 124–126, 128–131, 139, 146, 148, 28, 33–34, 42–46, 50–54, 61–64, 72–76, 78, 86, 86, 86, 86, 86–87, 89, 89, 89–92, 94
pattern_brush.class.ts	5.26%	0%	0%	8.33%	16, 20–23, 25–26, 26, 26–29, 37–38, 40, 44, 55, 55, 55, 63–65, 65, 65, 72–73, 75–76, 76, 80
pencil_brush.class.ts	91.91%	85.42%	100%	93.64%	122–123, 152, 152–154, 276, 280, 285–286, 68–69, 84–85
spray_brush.class.ts	2.30%	0%	0%	3.08%	104–106, 108–109, 117, 117, 117, 117, 117–118, 120–121, 128–129, 131, 133–137, 146, 150–151, 151, 159, 159, 159–162, 164–167, 171–172, 174, 176–179, 182, 189–190, 192, 194–195, 197, 204–205, 207–208, 211, 211, 218, 218, 222, 27–28, 30–32, 32, 32–34, 38, 47, 54, 61, 68, 75, 82, 94–96
src/color
color.class.ts	91.67%	84.51%	100%	94.44%	325–326, 330–331, 334–335, 41, 45, 72–73, 73, 75, 75, 75–76, 78–79
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
index.ts	100%	100%	100%	100%
util.ts	100%	100%	100%	100%
src/controls
actions.ts	100%	100%	100%	100%
changeWidth.ts	100%	100%	100%	100%
control.class.ts	93.98%	88.89%	90.91%	97.78%	236, 320, 320, 355
controls.render.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
default_controls.ts	72.73%	50%	100%	100%	109, 113, 120
drag.ts	100%	100%	100%	100%
rotate.ts	20%	12.50%	50%	22.22%	44, 50, 50, 50–51, 54–56, 58, 58, 58, 58, 58–60, 60, 60–62, 64, 64, 64–66, 66, 66–67, 72, 72, 72–73, 75, 77, 79–80
scale.ts	94.41%	94.74%	100%	93.59%	129–130, 132–134, 181–183, 42
scaleSkew.ts	80.56%	66.67%	100%	92.31%	14, 28, 30, 30, 30, 32, 34
skew.ts	91.03%	79.31%	100%	97.67%	131–132, 163–164, 171, 177, 179
util.ts	100%	100%	100%	100%
wrapWithFireEvent.ts	100%	100%	100%	100%
wrapWithFixedAnchor.ts	100%	100%	100%	100%
src/filters
2d_backend.class.ts	92%	83.33%	100%	93.75%	35–36
FilterBackend.ts	88.89%	83.33%	100%	90%	11–12
WebGLProbe.ts	40.54%	40%	60%	36.36%	28–30, 30, 30–31, 33–35, 43, 46–48, 48, 48–51, 53, 58
base_filter.class.ts	22.35%	20.41%	38.10%	20%	100, 102–104, 104, 104–105, 112–114, 114, 114–115, 122–125, 125, 125–126, 132, 132, 132–135, 153, 183–188, 192–193, 193, 193–196, 196, 196, 196, 196–198, 204, 213–214, 219–223, 266–269, 285, 285, 285–286, 288, 304–306, 306, 306, 306, 306–307, 309, 311–312, 314–315, 317–319, 327–328, 33, 330, 334–336, 340, 340, 340, 344, 344, 344–345, 367, 367, 367–371, 54–55, 83–84, 86, 86, 86–87, 87, 90, 95–97, 99, 99, 99, 99, 99, 99
blendcolor_filter.class.ts	10%	4.76%	28.57%	9.72%	104, 126, 128, 128, 128–130, 135, 145–147, 155, 157–160, 162–165, 167, 167, 167, 167, 167, 167, 167, 167, 167, 167, 167, 167, 169–172, 174–177, 179–182,

ShaMan123

Finally after redoing everything I found the very very minor error in coversion.
It was hidden in fromObject, didn't pass src

asturur · 2022-11-24T22:18:39Z

src/shapes/image.class.ts

+/**
+ * @tutorial {@link http://fabricjs.com/fabric-intro-part-1#images}
+ */
+export class Image extends FabricObject {


this name is a pain as it is Object now. doing new Image() can't be really done.

I agree, wasn't sure what to do cause if we name it FabricImage then maybe every thing should become FabricXXX

src/shapes/image.class.ts

ShaMan123 added 9 commits November 17, 2022 15:41

transform

965fb27

auto

887d55c

Update objectEnlive.ts

f443f2f

Update objectEnlive.ts

024a735

Update image.class.ts

178d799

Update image.class.ts

0f877ab

Update parseAttributes.ts

fee264a

Update image.js

3c8c0a6

Update image.class.ts

d08852e

ShaMan123 commented Nov 17, 2022

View reviewed changes

src/shapes/image.class.ts Show resolved Hide resolved

ShaMan123 commented Nov 17, 2022

View reviewed changes

src/shapes/image.class.ts

* @param filtered

* @deprecated

*/

getSvgSrc(filtered?: boolean) {

Copy link

Contributor Author

ShaMan123 Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

ShaMan123 commented Nov 17, 2022

View reviewed changes

Update image.class.ts

5cf26fb

ShaMan123 commented Nov 17, 2022

View reviewed changes

ShaMan123 added 2 commits November 17, 2022 17:25

Update image.class.ts

1db3ff6

refactor(): setElement

864a5f2

remove `_initElement`

Merge branch 'master' into ts-image

f9a9896

ShaMan123 commented Nov 20, 2022

View reviewed changes

src/shapes/image.class.ts Outdated Show resolved Hide resolved

src/shapes/image.class.ts Outdated Show resolved Hide resolved

src/shapes/image.class.ts Show resolved Hide resolved

ShaMan123 added 8 commits November 20, 2022 18:39

extract

6e67f45

filterBackend => getFilterBackend

12d9092

Update CHANGELOG.md

92cba99

fix

e4ba060

no chains

ff831e6

Update FilterBackend.ts

fa6bd08

fix!

3889c93

not defaultOptions, default props

7493d3e

ShaMan123 commented Nov 20, 2022

View reviewed changes

src/shapes/image.class.ts Show resolved Hide resolved

ShaMan123 added 2 commits November 20, 2022 19:16

fix applyFilters

658bfb6

redo

b7c26f7

ShaMan123 added 3 commits November 21, 2022 13:10

types

27c4ccf

finally found the bug

95c8c96

constructor overloads

8bb4cf5

ShaMan123 commented Nov 21, 2022

View reviewed changes

Merge branch 'master' into ts-image

23c9ac0

asturur reviewed Nov 24, 2022

View reviewed changes

src/shapes/image.class.ts Show resolved Hide resolved

asturur reviewed Nov 24, 2022

View reviewed changes

src/shapes/image.class.ts Show resolved Hide resolved

asturur approved these changes Nov 24, 2022

View reviewed changes

asturur merged commit b5b8e72 into master Nov 24, 2022

asturur deleted the ts-image branch November 27, 2022 00:15

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023

chore(TS): migrate Image (fabricjs#8443)

886fe45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(TS): Image #8443

chore(TS): Image #8443

ShaMan123 commented Nov 17, 2022

github-actions bot commented Nov 17, 2022 •

edited

ShaMan123 Nov 17, 2022

ShaMan123 Nov 17, 2022

ShaMan123 Nov 17, 2022

ShaMan123 left a comment

asturur commented Nov 19, 2022

ShaMan123 commented Nov 19, 2022

ShaMan123 left a comment

github-actions bot commented Nov 21, 2022 •

edited

ShaMan123 left a comment •

edited

asturur Nov 24, 2022

ShaMan123 Nov 25, 2022

chore(TS): Image #8443

chore(TS): Image #8443

Conversation

ShaMan123 commented Nov 17, 2022

Motivation

Description

Changes

Gist

In Action

github-actions bot commented Nov 17, 2022 • edited

ShaMan123 Nov 17, 2022

Choose a reason for hiding this comment

ShaMan123 Nov 17, 2022

Choose a reason for hiding this comment

ShaMan123 Nov 17, 2022

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

asturur commented Nov 19, 2022

ShaMan123 commented Nov 19, 2022

ShaMan123 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2022 • edited

ShaMan123 left a comment • edited

Choose a reason for hiding this comment

asturur Nov 24, 2022

Choose a reason for hiding this comment

ShaMan123 Nov 25, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2022 •

edited

github-actions bot commented Nov 21, 2022 •

edited

ShaMan123 left a comment •

edited