Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Rename files #8621

Merged
merged 13 commits into from Jan 24, 2023
Merged

chore(): Rename files #8621

merged 13 commits into from Jan 24, 2023

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Jan 24, 2023

Motivation

Description

rename:

  • shapes
  • canvas files
  • brushes
  • filters
  • files under src
    • Pattern
    • Point
    • Intersection
    • Shadow
  • color
  • gradient
  • control class

Changes

Gist

In Action

@github-actions
Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 938.430 (0) 295.964 (0)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

Coverage after merging rename into master will be

82.95%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
index.ts100%100%100%100%
src
   Collection.ts95.48%94.74%89.66%97.73%205–206, 231–232
   CommonMethods.ts96%80%100%100%10
   Intersection.ts100%100%100%100%
   Observable.ts87.23%85.29%84.62%89.36%138–139, 164–165, 39–40, 48, 57, 91, 99
   Pattern.ts93.85%90.32%100%96.15%100, 124, 135, 144
   Point.ts100%100%100%100%
   Shadow.ts98.48%96%100%100%156
   cache.ts96.97%90%100%100%56
   config.ts77.27%66.67%66.67%84.62%130, 138–140, 151–153
   constants.ts100%100%100%100%
   env.ts72.73%53.33%100%79.17%22, 22–23, 23, 23, 25, 25, 27, 29, 31–32, 62
   typedefs.ts100%100%100%100%
src/brushes
   BaseBrush.ts100%100%100%100%
   CircleBrush.ts0%0%0%0%100, 102–104, 113, 113, 113, 115, 117, 119–121, 123–126, 134, 141, 143, 28–29, 37–41, 45–49, 56–59, 67–71, 73, 81, 81, 81, 81, 81–82, 84, 84, 84–87, 89, 97–98
   PatternBrush.ts97.06%87.50%100%100%21
   PencilBrush.ts91.81%85.42%100%93.52%122–123, 152, 152–154, 276, 280, 285–286, 68–69, 84–85
   SprayBrush.ts0%0%0%0%100–101, 103–104, 112, 112, 112, 112, 112–113, 115–116, 123–124, 126, 128–132, 141, 145–146, 146, 154, 154, 154–157, 159–162, 166–167, 169, 171–174, 177, 184–185, 187, 189–190, 192, 199–200, 202–203, 206, 206, 213, 213, 217, 22–23, 25–27, 27, 27–29, 33, 42, 49, 56, 63, 70, 89–91, 99
src/canvas
   Canvas.ts78.85%76.85%83.33%79.58%1010–1011, 1011, 1011–1013, 1015–1016, 1016, 1016, 1018, 1026, 1026, 1026–1028, 1028, 1028, 1034–1035, 1043–1044, 1044, 1044–1045, 1050, 1052, 1083–1085, 1088–1089, 1093–1094, 1211–1213, 1216–1217, 1290, 1410, 1504–1505, 1511, 1515–1516, 1532, 1554, 1601, 1606, 1654, 172, 197, 306–307, 310–314, 319, 342–343, 348–353, 373, 373, 373–374, 374, 374–375, 383, 388–389, 389, 389–390, 392, 401, 407–408, 408, 408, 451, 459, 463, 463, 463–464, 466, 548–549, 549, 549–550, 556, 556, 556–558, 578, 580, 580, 580–581, 581, 581, 584, 584, 584–585, 588, 597–598, 600–601, 603, 603–604, 606–607, 619–620, 620, 620–621, 623–627, 633, 640, 680, 680, 680, 682, 684–688, 694, 700, 700, 700–701, 703, 706, 711, 724, 751, 751, 809–810, 810, 810–811, 813, 816–817, 817, 817–818, 820–821, 824, 824–826, 829–830, 900, 912, 919, 940, 972, 993–994
   SelectableCanvas.ts93.75%90.49%94.12%96.09%1137, 1137–1138, 1141, 1161, 1161, 1220, 1270–1271, 1292, 1300, 1413–1414, 1416–1417, 1437–1438, 556–557, 562, 572, 705–706, 708–709, 709, 709, 755–756, 817–818, 871–873, 903, 908–909, 938–939
   StaticCanvas.ts94.85%89.68%97.96%97.19%1086–1087, 1087, 1087–1088, 1208, 1218, 1272–1273, 1276, 1311–1312, 1389, 1398, 1398, 1402, 1402, 1449–1450, 1667, 1667–1668, 1717, 1720, 1723, 1723, 1723, 1726, 1729, 1729, 1729, 285–286, 383–384, 386–387, 846
   TextEditingManager.ts100%100%100%100%
src/color
   Color.ts92.16%86.49%100%94.29%330–331, 335–336, 339–340, 58, 88–89, 89, 91, 91, 91–92, 94–95
   color_map.ts100%100%100%100%
   constants.ts100%100%100%100%
   util.ts100%100%100%100%
src/controls
   Control.ts93.90%88.89%90.91%97.73%235, 319, 319, 354
   changeWidth.ts100%100%100%100%
   controls.render.ts81.63%78%100%84.78%106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
   default_controls.ts86.67%66.67%100%100%122, 129
   drag.ts100%100%100%100%
   polyControl.ts6.35%0%0%11.43%100, 105, 119, 121–124, 124, 127, 134, 17, 25–28, 30, 30, 30, 30, 30, 30, 30, 30, 50–56, 56, 56, 56, 56, 58, 63–64, 66, 76, 82–83, 83, 83–84, 88–90, 90, 90, 90, 90, 92
   rotate.ts20%12.50%50%22.22%45, 51, 51, 51–52, 55–57, 59, 59, 59, 59, 59–61, 61, 61–63, 65, 65, 65–67, 67, 67–68, 73, 73, 73–74, 76, 78, 80–81
   scale.ts93.41%92.68%100%93.59%129–130, 132–134, 148–149, 181–183, 42
   scaleSkew.ts78.79%64.29%100%85.71%27, 29, 29, 29, 31, 33, 35
   skew.ts91.03%79.31%100%97.67%130–131, 162–163, 170, 176, 178
   util.ts100%100%100%100%
   wrapWithFireEvent.ts100%100%100%100%
   wrapWithFixedAnchor.ts100%100%100%100%
src/filters
   BaseFilter.ts19.88%20.83%30%17.35%100–102, 102, 102–103, 110–113, 113, 113–114, 120, 120, 120–123, 141, 171–176, 180–181, 181, 181–184, 184, 184, 184, 184–186,

Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another ready no brainer
Filters in a dedicated PR cad29d3

@asturur asturur merged commit 84b7a35 into master Jan 24, 2023
@ShaMan123 ShaMan123 deleted the rename branch January 24, 2023 13:03
ShaMan123 added a commit that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants