Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS(): Testing fabric 6 package configuration and code splitting. Fix fabric object access #8622

Merged
merged 19 commits into from
Feb 2, 2023
Merged

TS(): Testing fabric 6 package configuration and code splitting. Fix fabric object access #8622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9c01ab1
module config
asturur Jan 24, 2023
3e9dad0
save so far
asturur Jan 27, 2023
a59eb23
Merge branch 'master' into v6-package-testing
asturur Jan 27, 2023
3fb6cd4
remove build
asturur Jan 27, 2023
248066b
missin file
asturur Jan 27, 2023
8033843
build is ok, types are not
asturur Jan 28, 2023
6c43775
build is ok, types are not
asturur Jan 28, 2023
536b644
different import
asturur Jan 28, 2023
40af839
where are my types
asturur Jan 29, 2023
887b288
declaration are back
asturur Jan 29, 2023
3b459fc
progress;
asturur Jan 30, 2023
f3ab5d0
no unused deps
asturur Jan 30, 2023
ddbf31e
fixed fabric access
asturur Jan 30, 2023
8a0638a
fixed fabric access
asturur Jan 30, 2023
edc36d0
pretty and changelog
asturur Jan 30, 2023
1f8583c
try different
asturur Jan 30, 2023
ce1874b
fix tests to do not reference fabric
asturur Jan 30, 2023
7d22d71
Squashed commit of the following:
ShaMan123 Jan 31, 2023
633a33c
Revert "Squashed commit of the following:"
ShaMan123 Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"presets": [
"@babel/env",
["@babel/env"],
[
"@babel/typescript",
{
Expand Down
19 changes: 19 additions & 0 deletions .babelrcAlt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"presets": [
[
"@babel/env",
{
"modules": false,
"useBuiltIns": false,
"loose": true,
"targets": "chrome > 100"
}
],
[
"@babel/typescript",
{
"allowDeclareFields": true
}
]
]
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be an alternative config file, very loose, that would behave as tsc, just stripping types.
This could be useful for developers that want to import files directly and then want to bundle and transpile on their own.

4 changes: 3 additions & 1 deletion .browserslistrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Browsers that we support

chrome >= 58
chrome >= 64
safari >= 11
firefox >= 58
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those for examples are browsers released Jan 2018.
But to be honest i would like to decide by canvas features.
Like which is the minimum set of browsers with advanced text metrics?
For the beta is not relevant we can readjust

1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [next]

- chore(): Change import and export strategy [#8622](https://github.com/fabricjs/fabric.js/pull/8622)
- chore(): rename files to modern style [#8621](https://github.com/fabricjs/fabric.js/pull/8621)
- chore(): move and rename text & itext files and organize as folders, rename mixins [#8620](https://github.com/fabricjs/fabric.js/pull/8620)
- chore(TS): type IText, IText behavior, IText click behavior [#8610](https://github.com/fabricjs/fabric.js/pull/8610)
Expand Down
Loading