fix(TS): add types to untyped empty arrays #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jasonkang14 thank for the PR. |
|
@asturur i see that it has failed some tests. should i try to add more fixes? |
|
No those steps fails because you work from a fork and that is epxected. |
|
Done!
|
asturur
approved these changes
Apr 12, 2023
jasonkang14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was trying to deploy my service using the beta version but ran into some type errors
I added types to the specific section in the screenshot and found other areas where similar problems may occur
Description
Add types to an empty arrays that takes fabric objects as elements
Changes
empty arrays in
CircleBrush.ts,SparyBrush.ts,parseColorStops.ts,Intersection.tsare now declared with typesGist
In Action
passed all the tests
